Tagadelic block cache displays wrong tags [#391930]

This way, the tag clouds caches will be wiped each time a node or a taxonomy term is added/edited/deleted. At line 232, just replace
cache_set($cache_name, $tags, 'cache', CACHE_TEMPORARY);
by
cache_set($cache_name, $tags, 'cache_page', CACHE_TEMPORARY);

As cache_page is wiped each time a node or a taxonomy term is added/edited/deleted, there will be no inconsistency on the tag cloud.

Does that sound good?

Comment	File	Size	Author
#1	tagadelic_cache_page.patch	934 bytes	David Stosik

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

David Stosik CreditAttribution: David Stosik commented 5 March 2009 at 13:33

File	Size
tagadelic_cache_page.patch	934 bytes

By the way, cache_get shoul also be changed! :)
Here is a patch that can be tested on 6.x-1.x-dev and 6.x-1.2.

Comment #2

David Stosik CreditAttribution: David Stosik commented 5 March 2009 at 13:33

Status:

Active

» Needs review

Comment #3

David Stosik CreditAttribution: David Stosik commented 12 March 2009 at 10:43

Hello, anybody's opinion on this?
I changed the title to reflect my problem.
When I create or remove a tag, tagadelic's block displays an old cached version not taking into account the changes I just made.
If tagadelic blocs are cached in cache_page, then the problem is solved, as this cache table is flushed whenever an action on nodes or tags is done.

Comment #4

pyxio CreditAttribution: pyxio commented 12 March 2009 at 05:02

Title:

Tagadelic cache should be set in cache_page table

» Tagadelic block cache displays wrong tags

I'm having the same problem. Where is cache_page located???? Thanks! Kevin

Comment #5

David Stosik CreditAttribution: David Stosik commented 12 March 2009 at 10:44

Hello,
cache_page is a Drupal core cache table in the database.
Applying my patch only changes, in Tagadelic module, the cache table used, from 'cache' table, to 'cache_page' table.

Comment #6

pyxio CreditAttribution: pyxio commented 12 March 2009 at 13:30

Hi David,

Thanks for the heads up. I'm new to Drupal and have never installed a patch before. It looks like I need to copy and paste your code somewhere? Into one of the Tagadelic files? Can you please give me step-by-step instructions? As an aside, this seems to be a major issue. Is it being addressed in the next version? Cheers, Kevin

Comment #7

David Stosik CreditAttribution: David Stosik commented 14 March 2009 at 12:10

Hello iteego.
Either you follow the instructions to apply a patch, or, as this patch is simple, you open tagadelic.module with a text editor, then, replace the lines in the patch starting with a '-' by those starting with a '+'.

Regards,
David