Javascript stops working with empty tabs - F is undefined [#813800]

It seems now if there is an incomplete / empty tab, the module breaks all the JS on the site.
I could not debug perfectly, but maybe this was the problematic part:

<div id="tabs-tabset" class="drupal-tabs js-hide"><div class="description"></div><ul class="clear-block"></ul></div>  </div>

I added a try-catch block to make it more robust. It's not an elegant solution, maybe you have a better idea to fix this inside the .module function. But at least it makes the JS code secure in that way that it does not break other JS at the site.

Comment	File	Size	Author
#5	813800_tabs_js_empty_tabs.patch	1.4 KB	Aron Novak
	tabs_better_js.patch	2.42 KB	Aron Novak

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Aron Novak

Hungarian

Hungary, Budapest

CreditAttribution: Aron Novak commented 31 May 2010 at 10:52

Status:

Active

» Needs review

Comment #2

opteronmx CreditAttribution: opteronmx commented 17 September 2010 at 22:06

Title:

Make the javascript of Tabs more robust

» Javascript stops working with empty tabs - F is undefined

Changing title to be more descriptive.
-------

Issue confirmed.

I have the same issue on a node type with fieldgroups rendered as tabs. When all the fields inside the fieldgroups are empty, all the javascript on my site stops working.

Also, when I change from a browser's tab to another, I get the follow JS error on firebug:

"F is undefined"

On jquery_update.module's replacement file (jquery.min.js) for default drupal's jquery one. Or:

"elem is undefined"

on line

var id = elem[ expando ];

in the non-minimized jquery.js file.

The patch works, but I think that there must not be even an output on this conditions (all fields and all tabs empty). I've tried to fix it on tabs.module, but I didn't find what to validate as !empty().

Comment #3

nedjo

he/him/his

English

CreditAttribution: nedjo commented 3 November 2010 at 16:31

Status:

Needs review

» Needs work

Yeah, I think this needs to be done on the PHP side.

Comment #4

mogop CreditAttribution: mogop commented 27 December 2010 at 18:29

Had the same problem before.
I applied your patch but still can't load tabs even when they are not empty. maybe there is conflict with jquery_ui?

Failed to load resource: the server responded with a status of 403 (Forbidden)
/drupal/sites/all/modules/jquery_ui/jquery.ui/ui/packed/ui.tabs.packed.js?wFailed to load resource: the server responded with a status of 403 (Forbidden)