Some of the settings specified by data attributes were not working for me. I found it was because Chrome lower-cases the attribute names. After some digging I found that attribute names should be lower case, at least according to the HTML 5 standard (e.g. see http://stackoverflow.com/a/25033330/1133481). Attached is a patch that adds support for both the original camel-cased names and lower-cased names.

CommentFileSizeAuthor
#3 table_chart-support_lower_case_attributes-2725933-2.patch7.64 KBOliverColeman
#2 table_chart-support_lower_case_attributes-2725933-1.patch7.52 KBOliverColeman

Comments

OliverColeman created an issue. See original summary.

OliverColeman’s picture

OliverColeman commented
StatusFileSize
new table_chart-support_lower_case_attributes-2725933-1.patch7.52 KB
OliverColeman’s picture

OliverColeman commented
StatusFileSize
new table_chart-support_lower_case_attributes-2725933-2.patch7.64 KB

Oops, first patch didn't handle boolean options.

bbeellkk’s picture

bbeellkk commented

Thank you for the prepared patch, it is helpful.

Are there any estimates when it is included into the module code by default?

persuader’s picture

persuader commented
persuader’s picture

persuader commented

None of the patches seems to apply it returns .

patching file table_chart.js
patch: **** malformed patch at line 131:

how can i fix this ?

minoroffense’s picture

minoroffense commented

The code looks fine. I like the check happening. I guess we'll have to deprecate the old names in a later release.

I'll test the code out on a few sites and if it works I'll merge it in.

minoroffense’s picture

minoroffense commented

I had to fix the patch (wouldn't apply) but I created a branch to test the changes out on. I'll add it to a few sites to see if there are any issues.