The module should be converted to short arrays as per new coding standard

CommentFileSizeAuthor
#3 synonyms_array_search_results.png144.97 KBdhruveshdtripathi
#2 2877885-2.patch16.16 KBPavan B S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Status: Active » Needs review
FileSize
2877885-2.patch16.16 KB

Applying the patch, please review

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
synonyms_array_search_results.png144.97 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier here were 39 array declarations, after applying patch there are 9. Those 9 array declarations are in_array and is_array.

Good work!

  • bucefal91 committed 7df8d73 on 8.x-1.x 
    Issue #2877885 by Pavan B S, bucefal91: Improving coding style.
bucefal91’s picture

bucefal91 CreditAttribution: bucefal91 at Websolutions Agency commented
Status: Reviewed & tested by the community » Fixed

With the latest commit there was another additional occurrence that I also fixed.

P.S. You can do grep -r "array(" . | grep -v "in_array" | grep -v "is_array" | wc -l to exclude the 2 false positives :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

devad’s picture

devad CreditAttribution: devad as a volunteer commented
Version: 8.x-1.x-dev » 2.0.x-dev