Closed (fixed)
Project:
Mailer Plus (DSM+)
Version:
1.3.0-beta1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 May 2023 at 12:17 UTC
Updated:
29 May 2023 at 11:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
adamps commentedThanks for the report. I haven't started using D10 yet so I can't confirm.
Please can you add more details:
Comment #3
chike1. As soon I enable the module the error shows and site breaks.
2. I got this stack trace,
Comment #4
adamps commentedThanks. It could be caused by #3355846: Circular reference on multi-language sites - maybe
OverrideManageris callingEntityTypeManager->getDefinition()in the middle of trying to createEntityTypeManager.Comment #5
fbreckx commentedSame here!
Comment #6
adamps commented#3355846: Circular reference on multi-language sites has now been fixed in the latest dev. Please try it and see if it also fixes this problem.
Comment #7
valicRemoving loading overrides on the hook hook_mailer_builder_info_alter installs the module usually. (using latest dev with mentioned fixes for circular reference / multi-language site)
Not sure what those overrides are used for, but this seems as close as possible to hit a circular reference
Drupal starts to process hooks:
- reaches
symfony_mailer_mailer_builder_info_alter- that hook then has a call towards
symfony_mailer.override_manager which represents \Drupal\symfony_mailer\Processor\OverrideManager-
OverrideManagerclass is injecting\Drupal\symfony_mailer\Processor\EmailBuilderManager, which in fact, provides the hooks above to exist at all (any mailer_builder_info hook)Comment #8
adamps commentedThis patch might fix it (but it is a guess as I don't see the bug anyway). Please can someone test?
If you still see the problem with the latest dev release and the patch, please can you upload a new stack trace?
Does anyone see this on D9 or is it D10 only?
Comment #9
chikeThe patch on the latest dev release solved the issue.
Comment #10
adamps commentedThanks for confirmation. Please can you clarify?
Comment #11
chikeI actually wanted to test this so I first tried the dev release alone and the issue wasn't solved then I applied patch #8 and the issue was solved.
Comment #13
adamps commentedThanks