Remove incorrect version data from info file [#445294]

The info file says this is version 6.2 which makes the Update status module report that this is an unsupported version, creating big red error messages in the administration area for anyone who deploys from cvs. The version number is added by the packaging script to the tarball but should not be in the cvs file.

Comment	File	Size	Author
#3	445294-remove_version_from_info.patch	554 bytes	xurizaemon

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sammys CreditAttribution: sammys commented 16 July 2009 at 19:17

Yes. Please fix it so the available updates page can stop complaining that your module is installed. :)

Comment #2

spydmobile CreditAttribution: spydmobile commented 28 September 2009 at 21:33

Subscribing

Comment #3

xurizaemon

he/him

Ōtepoti, Aotearoa 🏝

CreditAttribution: xurizaemon commented 14 February 2011 at 19:48

Title:	No version in info file	» Remove incorrect version data from info file
Priority:	Normal	» Major
Status:	Active	» Needs review

File	Size
445294-remove_version_from_info.patch	554 bytes

In case having a patch will make this any easier to fix ...

Currently swfobject_api.info for 6.x-1.x-beta1 contains

version = "6.x-2.0"

That line should not be included in the CVS file; it should be automatically added by the d.o packaging script.

The result of the duplicate inclusion is that the module triggers an update warning about an unsupported module version being installed, as KarenS says above.

@arthurf, this is a trivial issue to fix and will help six thousand sites (give or take) not see a meaningless module warning on their available updates page.

If SWFObject API module doesn't cry wolf every time, those admins are a lot more likely to take actual updates seriously.

Please fix this issue.

Comment #4

arthurf CreditAttribution: arthurf commented 14 February 2011 at 19:57

Thanks for the patch. Can you test the dev version to make sure it's functioning as expected? I don't have a test environment handy to determine if I should cut a new tag from dev.

Comment #5

xurizaemon

he/him

Ōtepoti, Aotearoa 🏝

CreditAttribution: xurizaemon commented 14 February 2011 at 20:09

Thanks for the quick response!

I'm presuming you mean 6.x-1.0-beta1 when you say "dev"? The patch above is the only change we've made to that version. No -dev releases I can see for this module.

I expect we're only using the most common functionality ourselves (on maybe 4~5 sites), but there are 6~9K sites on 6.x and you're not swamped with issues - that's gotta be a good sign :)

Ironically, the fact that people have been ignoring the update notification for this module for a while may prevent many of them upgrading to an actual 6.x-1.0. They are still going to see that their installed version of 6.x-1.0-beta1 reported as 6.x-2.0 ... if only update status displayed release notes inline :S ... but let's spare as many souls and sites as we can!

IMO having the updates page report the first version string, rather than the second entry (letting packaging script override) is something we could/should fix in the update code. Separate issue of course.