Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In case the browser has no flash player installed, this module outputs a "No flash detected" error message. This message is "Sorry, you need to install flash to see this content." by default.
As indicated in the module readme.txt, this module supports overriding of this message, using the 'no_flash' parameter key.
Unfortunately, overriding does not work.
It seems that the reason is that the wrong parameter is used in the theme_swfobject_api function: the default settings are used instead of the settings coming from the function parameters.
Comment | File | Size | Author |
---|---|---|---|
#1 | SWFObject_API-issue257043-patch1.patch | 455 bytes | Sebo |
Comments
Comment #1
Sebo CreditAttribution: Sebo commentedHere is a patch that fixes this issue.
Comment #2
arthurf CreditAttribution: arthurf commentedAh, I guess this one didn't make it into the 2.0 fixes. I added this and the search fix from #257076 to DRUPAL-5--2, let me know if that works for you.
Comment #3
arthurf CreditAttribution: arthurf commentedComment #4
Sebo CreditAttribution: Sebo commentedI've tried the DRUPAL-5--2 swfobject_api.module file you propose, but it seems there has been a lot of changes since the 2.0 Beta1 I am using, and I cannot see my flash app anymore...
=> good news: the error message is properly overriden (so your fix regarding this post is functional :-) )
=> bad news for me, I may need to changes other files for this new revision to work properly?
I have also tried with the DRUPAL-5 version of this file, and I have the exact same behavior...
I have 2 questions:
- I am wondering if the file version number is correct for the swfobject_api.module file:
in DRUPAL-5 version: 1.2.2.19
in DRUPAL-5--2 version: 1.2.2.8.2.1 ???? (it is a different branch?)
(I am using the last released module: 2.0 Beta 1, version: 1.2.2.9)
- Are there some other changes I need to make to use the latest CVS revision (either DRUPAL-5 or DRUPAL-5--2), compared to the Beta 1 release? (swfobject.js, ... ?)
Thanks for your help,
Seb
Comment #5
arthurf CreditAttribution: arthurf commentedYes, DRUPAL-5--2 is a different branch- it's for swfobject api 2.0. Are you using this? Are you seeing JS errors, and if so, what are you seeing?
Comment #6
Sebo CreditAttribution: Sebo commentedYes, I am using the 2.0 branch (I use the archive available on the module page called 2.0 Beta 1).
The problem is that with this version of swfobject_api, I do not see my flash player anymore! Instead I see the string saying that I need to install flash.
I am not used to debug JS. By running firebug, I can see an error reported in the console:
syntax error
[Break on this error] so1.write("flashcontent_mediaplayer_1"); -->
It corresponds to the code embedded where the flash player should display.
The whole code generated by swfobject_api is the following:
(The sentence "Pas de lecteur flash..." is my replacement for "Sorry, you need to install flash to see this content.".)
Comment #7
Sebo CreditAttribution: Sebo commentedFor information, I have replaced the 2.0Beta swfobject_api module by the 1.2-15 revision (last official release available in download, using swfobject 1.5), and everything works fine: my flash player displays properly. There may have been a regression in recent evolutions of the 2.0 branch?