The subscriptions_add_form simply sets the #access property to the setting value. From the user preference form, it appears the value should be greater than 0 to be TRUE.

Patch attached.

CommentFileSizeAuthor
#3 sub_add_respect_visiblity_settings.patch1.26 KBpattersonc
sub_add_respect_visiblity_settings.patch1.41 KBpattersonc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pattersonc’s picture

pattersonc CreditAttribution: pattersonc commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, sub_add_respect_visiblity_settings.patch, failed testing.

pattersonc’s picture

pattersonc CreditAttribution: pattersonc commented
FileSize
sub_add_respect_visiblity_settings.patch1.26 KB

Making relative

pattersonc’s picture

pattersonc CreditAttribution: pattersonc commented
Status: Needs work » Needs review
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

Thank you for your patch, but can you actually reproduce a bug that needs fixing? How?

pattersonc’s picture

pattersonc CreditAttribution: pattersonc commented

Sure.

1. Set user defaults (or individual user settings to hide interval, etc.)
2. Visit subscriptions/add/[type]
3. Notice the controls are visible

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

I need an exact description of what you do (exact paths, states of controls, buttons you click, etc.), what you expect to get, and what you see instead.

No "etc.", brackets, or anything like that. Pick one precise test case.

pattersonc’s picture

pattersonc CreditAttribution: pattersonc commented

1. Clear subscriptions_user so it has only the default user entry.
2. Visit admin/config/system/subscriptions/userdefaults > Overview > Visibility of Controls
3. Select 'Completely Inaccessible to the user' for all three options.
4. Visit add/taxa/1 where 1 is a valid taxonomy id where subscriptions are allowed.
5. Notice drop-down, and two check boxes allowing user to select Interval and On Update, On Comment

Sorry it took so long to get back to you on this one. Let me know if you need anything else.

pattersonc’s picture

pattersonc CreditAttribution: pattersonc commented
Assigned: pattersonc » Unassigned
Issue summary: View changes
daudetalphonse’s picture

daudetalphonse CreditAttribution: daudetalphonse commented

Exact same issue here. Regardless of the visibility settings you choose in the admin, the column "on updates" is always visible to the user (in my case, user role = authenticated user).

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs review » Postponed (maintainer needs more info)

Re #8: I don't have any add/taxa/TID path.

Also, I'm not sure what happens if you "Clear subscriptions_user so it has only the default user entry." This is certainly not a supported operation.