Using user-modal module -- http://drupalcode.org/sandbox/amitaibu/1151178.git/shortlog/refs/heads/s...

I have noticed that $form_state['rebuild'] = TRUE causes an error.

Maybe we should remove it?

CommentFileSizeAuthor
#2 1155396-no-rebuild.patch471 bytesamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

Maybe we should remove it? == I don't understans why it needed, but it doesn't mean it's not needed ;)

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Active » Needs review
FileSize
1155396-no-rebuild.patch471 bytes

And here's the patch.

User modal -- http://drupal.org/sandbox/amitaibu/1151178 is using this, if you would like to test.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

This seems to be the last patch required for user-modal.

@casey,
DO you know why this was written to begin with?

casey’s picture

casey CreditAttribution: casey commented

Well I assumed that when you include a subform the wrapper form also contains other form input. In most cases you won't want to lose that. Maybe we can add an extra submit handler. I'll post an update in a few moments.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

> include a subform the wrapper form also contains other form input.

Yeah, that's not the case of user-modal.

> Maybe we can add an extra submit handler

Yes, this sounds as a better solution.