In File Styles 2.x, file styles don't exist for administrator defined image styles [#1058056]

In Styles 1.x, you had this code:

function file_styles_styles_presets() {
  ...
  foreach (image_styles() as $style_name => $style) {
    $presets['file'][$style_name]['image'] = array($style_name);
  }
  ...
}

In Styles 2.x, no such code exists in file_styles_styles_default_presets().

So in 1.x, when I added an image style "foo" via admin/config/media/image-styles/add, and then went to admin/config/media/types/manage/image/display, "File Style: foo" would be a format option for the file field. But in 2.x, it isn't.

This also means that if I upgrade a site from 1.x to 2.x that was using "File Style: foo", then it gets reverted to "Generic File" instead.

Was this an intentional change?

Comment	File	Size	Author
#7	file-styles-support-media-file-image-1058056-7.patch	3.91 KB	aaron

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

effulgentsia CreditAttribution: effulgentsia commented 16 March 2011 at 15:27

Assigned:

Unassigned

» effulgentsia

At DrupalCon, Aaron said this was not an intentional change. I'll work on a patch.

Comment #2

oxyc CreditAttribution: oxyc commented 16 March 2011 at 15:43

Seems like he abstracted this into effects. Currently that line of code exists in file_styles.effects.inc.
file_styles.admin.inc also has some code (commented out) for displaying effects in vertical tabs. I tried working on it but gave up for now.

Although, a proper patch for making image styles available, even if temporarily, would be much appreciated on my side at least. I've made a few attempts at revealing them as presets but they are all ugly hacks.

Active

» Fixed

fixed; commit at http://drupalcode.org/project/styles.git/commit/803247c

Comment #6

aaron CreditAttribution: aaron commented 27 May 2011 at 21:47

and at http://drupalcode.org/project/styles.git/commit/2c15e41 oops...

Comment #7

aaron CreditAttribution: aaron commented 1 June 2011 at 00:26

File	Size
file-styles-support-media-file-image-1058056-7.patch	3.91 KB

also committed this patch, which adds media styles as formatters.

Comment #8

aaron CreditAttribution: aaron commented 1 June 2011 at 00:31

oops, rather http://drupalcode.org/project/styles.git/commitdiff/fe77559?hp=d3c514acf... and http://drupalcode.org/project/styles.git/commitdiff/3cc6b9f?hp=fe775598d... (forgot to increment the update).

Comment #9

nyl_auster CreditAttribution: nyl_auster commented 1 June 2011 at 09:34

It works :)

I tried the latest version on the Git repository and It seems to me that problems are gone. Like Effulgentsia I could not use image presets defined in admin/config/media/image-styles on files styles.

With this update, now, I can.

Thx