title field gets displayed below body

I do not have any international module installed in Drupal 6 and I can see this issue.

The title appears below the body even if I change the ordering in it's content type.

The order has been correctly assigned in the theme function.

Having the same issue in 6.x-1.20...

Found out that enabling CCK causes the stormorganization title input field to be weighted to the bottom.
Will try to find more info on what's causing this exactly!

Cheers

Moved back to active. I have CCK installed and the bug is still there.

Marking #367422: Ticket title appears below the description during editing with CCK Content activated as a duplicate of this issue.

And that one is marked as a duplicate of this one...
Which forum thread is the one we need to have our eyes on now??

Cheers

Look at the status. This one is "active". ;-)

:) oops!

Just got this same problem - installed and enabled CCK and now the title field has dropped down below the description for the create ticket page and so on.

I have just reproduced this too.

Pages affected (that I can see):
- Storm Organization: Name field
- Storm Ticket: Name field
- Storm Note: Title field
- Storm Knowledge base: Title field

I recognise that this annoying for anyone that uses CCK, especially as CCK is useful for extending the default Storm fields so useful to have enabled at the same time even if there was no other need for it (which there often is).

This has been seen in other modules too. I hope to be able to get something done for this.

Fixed in Storm Knowledgebase: http://drupal.org/cvs?commit=201612
Fixed in Storm Note: http://drupal.org/cvs?commit=201616
Fixed in Storm Organization: http://drupal.org/cvs?commit=201618
Fixed in Storm Ticket: http://drupal.org/cvs?commit=201624

These changes will be in the next roll of the dev version (midnight), so please test out to make sure!

The fault was caused by a quirk (perhaps bug) or CCK that allocates a weight of 1 to the title field, and this overrides the weightings already set. Therefore, to solve, the weights needed to be shifted so that the title field was already at 1 and the others given appropriate values around this.

Marking as fixed, but I can't stress enough, please do test the -dev version and report back if you still get the issue.

Finally I was able to test version 6.x-1.22.

Note and Organization is fixed. Cannot test Knowledgebase since we do not use it.

As for Ticket, the title is still shown below. I tried clearing the cache to no avail.

For Storm Ticket, the title is not intended to be absolutely at the top - the Organisation, Project, Task, Category, Status and Priority are meant to be above.

Please the location of the fields in your installation?

I'm marking this back as fixed since the ordering is what was planned.

However, for consistency I would hope to see the title at the absolute top.

Reopening this because the ordering of fields for a ticket isn't matched when creating or dispalying the ticket.

My CCK ordering for tickets is:

Title
Menu settings
Description
File attachments
Custom field group
-- custom field 1
-- custom field 2

When I create a ticket in storm, I get this order:

Title
File attachments
Custom field group
-- custom field 1
-- custom field 2
Description

I can reorder the fields around with no problem, except for Description. Nothing prevents Description from appearing last in the ticket. Even if I move it to the top, it is displayed last.

Do other Storm nodes behave as you would like in this respect?

On Tasks, I moved File Attachments to be above Description, and it still displays below.

I created a new field for Projects and placed it above Description; it still displays below Description.

I don't have time to test them all, but it looks like the scope is beyond just Tickets.

I've done a bit of reading on this and this link #203957: drag-n-drop 'manage fields' tab would seem a good starting point.
It would also enable storm to present it's fields for re-ordering via CCK if needed.

I've had a play and the 'title' weight comes through okay but I can't get it working for 'body' as it doesn't return a weight.

Spoke too soon

I made the following changes to the stormticket.module stormticket_form function

Changing the title weight:
'#weight' => module_exists('content') ? content_extra_field_weight($node->type, 'title') : 1,

Changing the body weight:
$form['body_filter']['#weight'] = module_exists('content') ? content_extra_field_weight($node->type, 'body_field') : 4;

I've made a patch against the dev version for stormticket, this corrects the title/body placement in editing and also offers up the ability to re-order the Organization/Project/Task Group, Category/Status/Priority Group, Date/Duration Group and Price Group.

It will need testing

@sbogner - does this work for you?

Yes magnity - that works for tickets.

Actually - that works for the create/edit actions. In the display of a ticket, it appears that any fields I've added now appear first, prior to the Organization entry. I added a couple custom CCK fields that should appear below Description, and I have a module for attaching files (IMCE, I believe) and it's attachment is being displayed prior to the Organization line (should be after Description).

Okay I've had a stab at getting this working on the display as well.
Updated and attached patch.

@sbogner can you test and confirm it works?

Thanks
Mark

Looks good and works for me. If @sbogner also agrees, that's ready to go in.

It'll be a fairly simple port to the other modules too.

I wish I could say it works for me too - but it doesn't. Doesn't look any different than before. I'm new to applying patches, but I think I got it right - copied the patch file to storm/stormticket and ran patch < patch-343818_0.patch - it complained about a previous patch. So, I reapplied my Aug 8 dev version of storm, and then ran the patch (343818_0) without any errors. It looks fine when creating/editing, but the fields are still not displaying in the right places when displaying the ticket.

I cleared the cache on my site, just in case, and that didn't change anything.

The patch I supplied is a patch against two files so maybe this is where you're stumbling.

When I'm patching something I start with a clean dev of storm and download the patch to the modules folder then use
patch -p0 -i storm-343818.patch
This should then apply the patch to each changed file in the storm folder.

Give it a go and let me know.

Thanks for the tip Mark - I did that, and still have the issue. I re-extracted the dev version of storm, then ran patch as you described; didn't get any errors at all from patch. Still, the custom CCK fields are displaying before Organization.

Hmmm, just done the same and I also exhibit problems on the viewing the ticket.

I've had a quick look and although the code is correctly calling the content_extra_field_weight and retrieving correct results it doesn't seem to impact the CCK fields.

So you can re-order the none CCK fields and they appear in the correct order, but my CCK fields always seem to show at the end.

I'll have a look when I can.

Changing status

Well that was interesting getting to the bottom of that!!!
It seems CCK checks the first level of the array for re-ordering.
As the stormticket was nested in a couple of divs to enabling 'nicer' formatting CCK never picked up on it.

I've re-coded the stormticket display, but I'm not sure I like it.

However I would appreciate you testing, again you'll need to ensure you patch as per #29 as this patch introduces a small addition to Storms main css file

That fixes the ordering issue. I agree the display view doesn't look so nice. The edit screen doesn't list the values for organization, project, task, category, status and priority - which is definitely not good. I restored storm and cleared my site's cache - but still don't get those values in the edit screen. They were there before, right? When I try to create a ticket, I can't enter anything for those fields either.

Seems odd as the ammendments between patches didn't touch that function.
I've tested on a fresh dev with the patch from #33 and I see the fields.

url storm.ctscomputing.com
un stormtest
pw Storm-Test

Can you test the above site and see if you the fields?

From my point of view
- #26 is commit ready adding the functionality to reorder the groups.
- #33 is currently 'needs work' - we can't degrade the themeing for this issue.

Considering #293485: Integrate with CCK for D7, I'm also not too keen on introducing major changes simply for this issue, as once all Storm fields are covered by Fields in Core, I feel that this issue will be solved naturally anyway.

Am I correct in thinking that any further patches are likely to have the changes made in #26 anyway? If so, i'd suggest that I commit #26 and we work from that updated datum with any further changes.

Mark - It works fine for me on your test site. I agree with you - #26 is good to go; 33 needs work.

@sbogner - okay my site is latest dev version and three patches
- #343818: title field gets displayed below body
- #433294: Add filter status when lists are filtered
- #527982: Shortcuts to actions from list view

Are you still having the issue with the update/create screens on your own setup?

@Magnity/@sbogner - I've changed the theming so it's follows the storm defaults, can you check the test website and see if that's okay?

Thanks
Mark

The theming looks ok now - we'd also need to ensure that the field order defaults to the previous though - I suspect the ordering is currently due to your testing the link with CCK.

Updated patch attached.

@sbogner can you test and let me know?

Mark - I downloaded today's dev version, applied those three patches, and it all looks good to me. Thanks for your effort and assistance with this - I appreciate it!

No thanks needed, we're all here to make this better for everyone.
You only needed the patch from #40, the others we're for different issues that I'm involved with.

Keep posting and keep reviewing patches and together we'll all get this to what we want :)

Sorry - this isn't quite there yet.

When viewing a ticket after application of the patch, the description field looks odd (see especially when the description runs on to multiple lines). Also the links to expenses and timetrackings are pushed down below the main content.

That said - the description field doesn't look great even without the patch!...

Seems to work fine on your site though (#35)...

Okay, I've rolled up the patch again, looks fine in iexplore, firefox, chrome and safari.

I tried extending this methodology to projects and realised it still needs some work :(

Okay, having spend a good couple of hours on this I think I finally understand weighting in conjuction with CCK and also how to theme this correctly!!!

I've updated the code and applied it to Projects, Tasks and Tickets.

I've also taken the liberty to bring the three in to a consistent ordering of fields.

It's on the testing site mentioned in #35 and I've attached the patch.

Whoops forgot to change status :)

It looks good from the site in #35 - and i'll test the patch properly in due course.

Quite happy for the default order to be rationalised a bit.

Currently working through this patch - updated version attached.

Doesn't apply at the moment - I suspect due to changes from other issues.

@Magnity: If you want me to update against latest dev then I'd be happy to help.

I'm always happy for people to reduce my work!**

Only changes into #50 were that I've committed the css and the theme registry bits had already been added.

** EDIT: Reduce never happens - always happy for people to allow me to spend more time getting to grips with the changes needed for D7...

Patched against latest dev

Minor update to correct DateAPI integration

Committed patch (for project, task, ticket).

Hence need to commit for expense, invoice, knowledgebase, note, organization, person, timetracking, and i'll revisit to do that in the next couple of days.

I'll extend to the others tomorrow and re-post, if that's okay with you

Even better! Thanks!

All other modules brought in to line.
It will probably need a good check, it was a fair amount of change!!

Committed. Thanks to Mark for your work getting all those patches done.

#59 on this issue makes it Storm's most active yet... lets hope that its fixed for good now!

Hey,
I am new to Drupal, and sorry for this might be seem very stupid question, but am facing this issue.
If I enable CCK title field appears below the body field. If I disable CCK then title field comes properly before the body field.

So do I have to apply this patch. How to I apply this patch?

http://drupal.org/patch/apply

Cheers

This patch was committed to the dev version in #343818-59: title field gets displayed below body
What version are you running on?

I am using version 6.14, the latest available on website.

Just below that - there is a link to 6.x-1.x-dev, and this is the version that Mark is referring to in #63.

If you're running on a production site and need a snapshot release, there should be another one soon - once a few changes to the team functionality has been finished.