Out of curiosity I've tested Storage Entities 1.1.0-beta3 on Drupal 9.3.0-alpha1. With Drupal 9.3.0 a "Manage permissions" tab is introduced on a per bundle basis showing its associated permissions only ( https://www.drupal.org/project/drupal/issues/2934995 ). If you create a Storage type and check the "Manage permissions" tab afterwards there are no permissions available for the newly created storage type

Manage permission tab for a storage type missing permissions

p.s. there is only beta1 and beta2 available for Storage Entities 1.1.0 in the issue metadata, beta3 is missing in the select box.

CommentFileSizeAuthor
manage_permissions.png60 KBrkoller

Issue fork storage-3247348

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rkoller created an issue. See original summary.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Issue summary: View changes
rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Issue summary: View changes
mxh’s picture

mxh commented
Version: 1.1.0-beta2 » 1.1.x-dev

Thanks for the issue report. You may just choose 1.1.x-dev in the Version dropdown selection, since that issue is not yet covered by the module in general.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented

true, you are right. just added the version i've tested against and taken the screenshot in. but 1.1.x-dev is the better choice. thanks for the advice will stick to the dev version when reporting for not yet or to be implemented functionality :)

mandclu’s picture

mandclu commented
Related issues: +#2934995: Add a "Manage permissions" tab for each bundle that has associated permissions, +#3253955: Let modules opt in to the bundle-specific permissions form

Marking #2934995: Add a "Manage permissions" tab for each bundle that has associated permissions and #3253955: Let modules opt in to the bundle-specific permissions form as related issues, since they speak to what is required to implement this. It sounds as the the former implemented a change that would make this tab automatically available, which would mean no action is required. That said, it seems the change was later reverted, but not in the 9.4.0 branch, so not yet clear what action is needed. The latter issue proposes an annotation change to make this tab available.

mandclu’s picture

mandclu commented
Title: Support for the "Manage permissions" tab coming in Drupal 9.3.0 for bundles » Support for the "Manage permissions" tab coming in Drupal 9.4.0 for bundles
mxh’s picture

mxh commented

This is the according change record: https://www.drupal.org/node/3242827

mandclu’s picture

mandclu commented

Good find. Based on the example there, it sounds like we need to add annotations to the StorageType class:

If you want to enable the new Permissions page for your entity type, then add the following keys to the annotations:

handlers.route_provider.permissions
links.entity-permissions-form

mandclu’s picture

mandclu commented

Returning back to this, based on what was committed in #2934995: Add a "Manage permissions" tab for each bundle that has associated permissions it looks like a single line needs to be added to the notation, something like:

* "permission-form" = "/admin/structure/storage/storage_types/{storage_type}//permissions",

Happy to work on this.

mandclu’s picture

mandclu commented
Status: Active » Needs work

I added the specified notations, and now the tab appears but the form is empty, as described in the issue. Not sure if the permissions are expected to have a certain structure in order to be picked up by the form. Will investigate this further, but marking this issue as Needs Work for now.