I'm still investigating this one. I'm working on a site that recently switched to Views 3.5 and I'm not getting error messages for this code.

http://drupalcode.org/project/state_machine.git/blob/bbc5defc7d0822ba339...

I think the latest Views changed the way it does joins between node and node revision.

CommentFileSizeAuthor
#3 published_handler-1775540-3.patch12.7 KBstevector
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robeano’s picture

robeano CreditAttribution: robeano commented
Issue tags: +Workbench Sprint

I'd like to see if we can tackle this one. Tagging for sprint.

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented
Assigned: Unassigned » stevector

I am working on a fix.

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented
Status: Active » Needs review
FileSize
published_handler-1775540-3.patch12.7 KB

Here's a fix that adds a test but I still don't know why exactly the additional_fields is broken. I'd rather not commit this in it's current state.

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented
Assigned: stevector » Unassigned
stevector’s picture

stevector
he/him
CreditAttribution: stevector commented
Status: Needs review » Active

I've committed this patch plus a @todo comment with a link back to this issue. I don't consider this issue fixed because the extra queries introduced by this patch are a problem.

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented

What I committed yesterday should have used the get_value() method. I've fixed that.

Elijah Lynn’s picture

Elijah Lynn
Location Portland, Oregon
CreditAttribution: Elijah Lynn commented
Issue summary: View changes
Status: Active » Needs work

Setting to needs work based on #5.