Problem/Motivation

SpambotUserspamForm should not extend ConfigFormBase because it isn't a configuration form, and it should place it's buttons inside 'actions' elements to ensure proper styling. Because it does extend ConfigFormBase, a form_alter function was needed to hide the Save Configuration button. When displayed, the form's buttons are not styled consistently with the rest of Drupal because the buttons are not nested within an actions element.

Comments

DanChadwick created an issue. See original summary.

danchadwick’s picture

Status: Active » Needs review
StatusFileSize
new4.58 KB

Status: Needs review » Needs work

The last submitted patch, 2: spambot-spam-tab-form-not-config-3211540-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

danchadwick’s picture

Status: Needs work » Needs review

Test failure was unrelated to this patch. I re-queued the test without any change, and it now passes

kala4ek’s picture

Assigned: Unassigned » kala4ek
kala4ek’s picture

Assigned: kala4ek » Unassigned
Status: Needs review » Fixed

  • DanChadwick authored 8b1b329 on 8.x-1.x
    Issue #3211540 by DanChadwick, kala4ek: SpambotUserspamForm should not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.