Blacklist IP variable misnamed [#1024646]

As I was reviewing all the variables, I noticed this one:

spam_blacklist_ip

It only appears in a variable_get() in the Duplicate filter:

$arguments = array(variable_get('spam_threshold', SPAM_DEFAULT_THRESHOLD), variable_get('spam_blacklist_ip', SPAM_FILTER_DUPLICATE_DEFAULT_BLACKLIST));

There is no UI to set the variable. (There is actually no other place where it appears from what I can see.)

If it is expected, it should be documented because at this point I would imagine that no one knows it exists and thus no one does anything with it.

Thank you.
Alexis Wilke

Comment	File	Size	Author
#2	spam-6.x-old_backlist_variable.patch	1.05 KB	AlexisWilke

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

gnassar CreditAttribution: gnassar commented 17 January 2011 at 11:56

Title:	Blacklist IP variable?	» Blacklist IP variable misnamed
Category:	task	» bug

SPAM_FILTER_DUPLICATE_DEFAULT_BLACKLIST as the default value should've been the giveaway here. Did you notice where else that was used as a default?

For example, line 88:

if ($spam_filter_duplicate_ip >= variable_get('spam_filter_duplicate_blacklist', SPAM_FILTER_DUPLICATE_DEFAULT_BLACKLIST)) {

Pretty much the same everywhere else you see that constant. The line you found obviously must be an old variable that didn't get changed, probably from a very old pre-5.x-3.x change. 'spam_blacklist_ip' should be 'spam_filter_duplicate_blacklist'.