Access to node/%node/edit controlled by OG instead of spaces and OG [#960318]

Spaces is -1. Og is 0. Spaces does it's menu alter. Og is does it's.

Bam, access callback for node/%node/edit is og_menu_access_node_edit instead of spaces_access_menu, so linking to node/%node/edit fails with patch for #936234 active (Tabs would trigger redirect, as it'd test access to the tab, so despite not being at that tab it would redirect).

This is the second time I've had issues with contrib modules running after spaces's menu alter (views unpublished for node/%node/view), making spaces_access_menu disappear. I think the menu alter runs too late and the weight should be at least 1 . I know there is a reason for it being -1, but I don't know why (I believe it was mentioned to me at some point, but forgot).

Comment	File	Size	Author
#6	spaces-960318-6.patch	4.36 KB	Dane Powell
#5	960318_spaces_spaces_og_weight.patch	4.07 KB	hefox
#1	960318_spaces_weight.patch	842 bytes	hefox

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hefox CreditAttribution: hefox commented 3 November 2010 at 01:27

Status:

Active

» Needs review

File	Size
960318_spaces_weight.patch	842 bytes

Here's a quickie patch.

Comment #2

Grayside CreditAttribution: Grayside commented 13 May 2011 at 18:29

Settings pre-patch:

Weight	Name	Version
-1	Spaces (spaces)	6.x-3.0-beta6
1	Spaces OG (spaces_og)	6.x-3.0-beta6
-19	Spaces User (spaces_user)	6.x-3.0-beta6

Wouldn't bad things potentially happen with Spaces and Spaces OG sharing a weight?

Comment #3

hefox CreditAttribution: hefox commented 9 November 2010 at 22:23

Ye, spaces_og_menu_alter needs to run after spaces_menu_alter to alter the items spaces_menu_alter adds, however there's a flaw in with that menu alter that #936234: call to router during menu access check causes infinite loop reveals; node/%node/features doesn't redirect (it was relying on other local tasks to redirect).

    $items['node/%node/features']['access callback'] = 'spaces_og_access_admin';
    $items['node/%node/features']['access arguments'] = array(1);

edit: Appreantly I meant to say more, and left a "However," at the bottom. I don't remember what I was going to say.

Comment #4

tylor CreditAttribution: tylor commented 9 November 2010 at 22:15

Status:

Needs review

» Needs work

I also noticed that you need to make sure boxes runs after spaces or you get a WSOD (seems that the spaces_controller class isn't loaded for spaces_controller_boxes).

Comment #5

hefox CreditAttribution: hefox commented 13 November 2010 at 19:38

Status:

Needs work

» Needs review

File	Size
960318_spaces_spaces_og_weight.patch	4.07 KB

Here's one with spaces_og.install.

Can ya make a patch for boxes?

(Let's see if my attempt to add a file via patch works...)

Comment #6

Dane Powell CreditAttribution: Dane Powell commented 9 August 2011 at 21:35

File	Size
spaces-960318-6.patch	4.36 KB

How has this been sitting here for so long? I was having a problem where trying to edit the Features for a Space result in access denied- adjusting the weights as in the patch above fixed the problem.

Unfortunately that patch will not apply for whatever reason. Here's an updated patch, with a couple of typos fixed.