Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Assigned: Harsh panchal » Unassigned
Category: Task » Bug report
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new22.54 KB

I have fixed phpcs standard issue and providing a patch.

jaykumar95’s picture

Issue summary: View changes

patch looks fine but only single typo I encounter is in this line
$data['solr_search_synonym_field_data']['uid']['relationship']['help'] = $this->t('The User ID of the synonym s author.');
should be
$data['solr_search_synonym_field_data']['uid']['relationship']['help'] = $this->t("The User ID of the synonym's author.");.

bhojwanipankaj05’s picture

Hi @harsh-panchal, I am reviewing your patch.

@jaykumar95, also checking your fix.

bhojwanipankaj05’s picture

bhojwanipankaj05’s picture

Hi @harsh-panchal,

Your patch #2 looks fine but it rejects on .info.yml file changes.

bhojwanipankaj05’s picture

Version: 1.0.1 » 1.0.4
Assigned: Unassigned » bhojwanipankaj05
Status: Needs review » Closed (works as designed)

Charchil Khandelwal made their first commit to this issue’s fork.