Closed (works as designed)
Project:
SOLR Search Synonym
Version:
1.0.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
4 Aug 2022 at 10:51 UTC
Updated:
31 Jan 2023 at 05:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Harsh panchal commentedI have fixed phpcs standard issue and providing a patch.
Comment #3
jaykumar95patch looks fine but only single typo I encounter is in this line
$data['solr_search_synonym_field_data']['uid']['relationship']['help'] = $this->t('The User ID of the synonym s author.');should be
$data['solr_search_synonym_field_data']['uid']['relationship']['help'] = $this->t("The User ID of the synonym's author.");.Comment #4
bhojwanipankaj05 commentedHi @harsh-panchal, I am reviewing your patch.
@jaykumar95, also checking your fix.
Comment #5
bhojwanipankaj05 commentedComment #6
bhojwanipankaj05 commentedHi @harsh-panchal,
Your patch #2 looks fine but it rejects on .info.yml file changes.
Comment #7
bhojwanipankaj05 commentedIssue fixed on release - https://www.drupal.org/project/solr_search_synonym/releases/1.0.4