When having latest dev revision installed and starting running the cron, following message shown up and reported:

WD theme: Theme hook icon not found. WD theme: Theme hook icon not found. WD theme: Theme hook icon not found. WD theme: Theme hook icon not found.

The reason is module icon not installed/enabled.

I'd suggest to add following content to file socialmedia.info:

dependencies[] = icon

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dooug’s picture

Status: Active » Needs review
FileSize
630 bytes

I also am seeing the error in the logs when editing the widgets defined by this module.

I looked at the code and it appears that the function socialmedia_widgets_element_info() defines some widgets that use theme('icon' ..., which is provided by the icon module. For example:
socialmedia.widgets.inc:59: 'template' => '<a class="addthis_button_facebook_follow[?link_class= {[socialmedia:sm-default_link_class_profile]}?]" addthis:userid="[?profile_username=[socialmedia:sm-facebook_userid]?]" title="Follow on Facebook">' . theme('icon', array('bundle' => 'enterprise_social', 'icon' => 'social-facebook')) . '</a>'

I uploaded a patch that adds icon as a dependency to socialmedia. I tested this, installing the icon module does resolve the error. Please review.

devad’s picture

Just a confirmation regarding dependancy on icon module.

After I have installed icon module "Theme hook icon not found." warnings stopped to appear into log messages.

dooug’s picture

@Devad, can you review & test the patch? It is simply adding the dependency for icon module.

devad’s picture

I'm sorry dooug... testing paches is not in my skills.

I can copy/paste dependency line into original .info file and try to install after that... but it is not what you ment i suppose.

dooug’s picture

@devad, No problem. For reference, this page gives some quick steps to apply a patch. It's worth it to learn this! :)

I'm just looking for someone to test and verify the patch resolves the issue.

devad’s picture

I'm on windows. Never dived into git.

TomDude48’s picture

I didn't intend to create a dependency with the Icon module. I removed the code that created the dependency in beta15.

devad’s picture

I have updated to beta15.

No more "Theme hook icon not found" warnings in log.

Thank you.

dooug’s picture

Status: Needs review » Closed (fixed)

Sounds like this is resolved.

upunkt’s picture

@TomDude48 Thanks for keeping the old code commented out in the new file. This made updating my custom version of socialmedia.widgets.inc very easy. Never got the point in keeping old code. Now I learned better.