When having latest dev revision installed and starting running the cron, following message shown up and reported:
WD theme: Theme hook icon not found. WD theme: Theme hook icon not found. WD theme: Theme hook icon not found. WD theme: Theme hook icon not found.
The reason is module icon not installed/enabled.
I'd suggest to add following content to file socialmedia.info:
dependencies[] = icon
Comment | File | Size | Author |
---|---|---|---|
#1 | socialmedia-dependency_on_icon-2264991-1.patch | 630 bytes | dooug |
Comments
Comment #1
dooug CreditAttribution: dooug commentedI also am seeing the error in the logs when editing the widgets defined by this module.
I looked at the code and it appears that the function
socialmedia_widgets_element_info()
defines some widgets that usetheme('icon' ...
, which is provided by the icon module. For example:socialmedia.widgets.inc:59: 'template' => '<a class="addthis_button_facebook_follow[?link_class= {[socialmedia:sm-default_link_class_profile]}?]" addthis:userid="[?profile_username=[socialmedia:sm-facebook_userid]?]" title="Follow on Facebook">' . theme('icon', array('bundle' => 'enterprise_social', 'icon' => 'social-facebook')) . '</a>'
I uploaded a patch that adds icon as a dependency to socialmedia. I tested this, installing the icon module does resolve the error. Please review.
Comment #2
devad CreditAttribution: devad commentedJust a confirmation regarding dependancy on icon module.
After I have installed icon module "Theme hook icon not found." warnings stopped to appear into log messages.
Comment #3
dooug CreditAttribution: dooug commented@Devad, can you review & test the patch? It is simply adding the dependency for icon module.
Comment #4
devad CreditAttribution: devad commentedI'm sorry dooug... testing paches is not in my skills.
I can copy/paste dependency line into original .info file and try to install after that... but it is not what you ment i suppose.
Comment #5
dooug CreditAttribution: dooug commented@devad, No problem. For reference, this page gives some quick steps to apply a patch. It's worth it to learn this! :)
I'm just looking for someone to test and verify the patch resolves the issue.
Comment #6
devad CreditAttribution: devad commentedI'm on windows. Never dived into git.
Comment #7
TomDude48 CreditAttribution: TomDude48 commentedI didn't intend to create a dependency with the Icon module. I removed the code that created the dependency in beta15.
Comment #8
devad CreditAttribution: devad commentedI have updated to beta15.
No more "Theme hook icon not found" warnings in log.
Thank you.
Comment #9
dooug CreditAttribution: dooug commentedSounds like this is resolved.
Comment #10
upunkt CreditAttribution: upunkt commented@TomDude48 Thanks for keeping the old code commented out in the new file. This made updating my custom version of socialmedia.widgets.inc very easy. Never got the point in keeping old code. Now I learned better.