I was getting improper URL error.

it is because 'www.' is expected for FB and Linkedin.

Can we change the regex so that either is acceptable?

CommentFileSizeAuthor
#18 1434720 config.png152.52 KBTomDude48
#18 1434720 result.png188.34 KBTomDude48
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented
Status: Active » Needs review

Fixed. Will be in next push.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Title: Linkedin and Facebook require "www" to be added others do not » Linkedin url appended to my base url

I installed the module and twitter, facebook and google + works.

LinkedIn points to http://judylarkins.com/%5B?profile_url=http://www.linkedin.com/profile/v...

That directs to my Page Not Found.

TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented

This should be fixed in the latest dev release.

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

when will the new dev be rolled out?

TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented

I want to get some testing on it and I have a couple more things I want to fix before rolling out a new release. Hopefully a week.

trante’s picture

trante CreditAttribution: trante commented

subscribe

trante’s picture

trante CreditAttribution: trante commented

When i add new buttons to my widgets, they shares this page:
"http://www.example.com/admin/structure/widgets/sets/edit/my_widget"

But i need module to share example.com.

trante’s picture

trante CreditAttribution: trante commented
Priority: Normal » Major

I suppose sharing "/admin/structure/widgets/sets/edit/my_widget" page is major, rather than normal.

trante’s picture

trante CreditAttribution: trante commented

I uninstalled dev version and installed "7.x-1.0-beta9".

Even this version shares this page:
"http://www.example.com/admin/structure/widgets/sets/edit/my_widget"

Do i miss something?

TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented
Status: Needs review » Postponed (maintainer needs more info)

Trante, I need more info on your issue. Which button are you trying to add? Can you send me a screenshot?

jlbretton’s picture

jlbretton CreditAttribution: jlbretton commented
Version: 7.x-1.x-dev » 7.x-1.0-beta9

same then #2 with beta11.
fb and twitter are fine.
linkedIn: I get http://exemple.com/[?profile_url=http://www.linkedin.com/profile/view?id...

hvdaal’s picture

hvdaal CreditAttribution: hvdaal commented
Title: Linkedin url appended to my base url » base url appended to LinkedIn and Facebook url
Version: 7.x-1.0-beta9 » 7.x-1.0-beta11

Link to LinkedIn and Facebook doesn't work. The base URL is added.
Twitter works.

In the browser appears: http://www.bankmutaties.nl/[?profile_url=http://www.facebook.com/profile...

PS. The dev and beta11 version are the same.

DigitalFrontiersMedia’s picture

DigitalFrontiersMedia
Location Sarasota, FL
CreditAttribution: DigitalFrontiersMedia commented

It appears that the module has a parsing issue with query strings in the link. Any address entered that includes a question mark/query parameter winds up being misinterpreted and being constructed as:
base_url/[?profile_url=social-media-site.com?query_string?]

Thus, entering:

http://www.facebook.com/pages/Vocalink/233499460021825?sk=wall

yields the following link FAIL in the active widget:
base_url/[?profile_url=http://www.facebook.com/pages/Vocalink/233499460021825?sk=wall?]

Dropping the query string ("?sk=wall"):
http://www.facebook.com/pages/Vocalink/233499460021825

yields the following correct link in the active widget:
http://www.facebook.com/pages/Vocalink/233499460021825

brentratliff’s picture

brentratliff CreditAttribution: brentratliff commented

I have also confirmed this bug. The query string is causing the token to be appended to the base url. Twitter is working correctly without a query string.

brentratliff’s picture

brentratliff CreditAttribution: brentratliff commented

I'm taking a look at function socialmedia_linkedin_parser($values). I'm the last person you want trying to decipher regex but I'm giving it a shot.

TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented
Status: Postponed (maintainer needs more info) » Needs review

DigitalFrontier, brentratliff,

I just tested using http://www.facebook.com/pages/Vocalink/233499460021825?sk=wall and http://www.linkedin.com/profile/view?id=5422390&trk=tab_pro. Both worked for me using the latest dev. Try the latest dev and let me know if this fixes the issue.

brentratliff’s picture

brentratliff CreditAttribution: brentratliff commented

No, I'm still experiencing the issue. Thanks for the quick responses.

TomDude48’s picture

TomDude48 CreditAttribution: TomDude48 commented
FileSize
1434720 result.png188.34 KB
1434720 config.png152.52 KB

brantratliff,

Are you using the latest dev? Also, clear you caches.

It is working for me, but maybe we are doing something different. I input http://www.facebook.com/pages/Vocalink/233499460021825?sk=wall as the facebook profile link. Then added the Widgets: socialmedia_profile-default to a region. The full link is then available.

I have attached screenshots.