Modal title bar is styled like this:

.ui-dialog-titlebar {
  display: -webkit-box;
  display: -ms-flexbox;
  display: flex;
  -webkit-box-align: center;
  -ms-flex-align: center;
  align-items: center;
  -webkit-box-pack: justify;
  -ms-flex-pack: justify;
  justify-content: space-between;
  padding: 12px 1rem;
  border-bottom: 1px solid #e6e6e6;
}

This results is modal title text displaying at some distance from the left edge of the modal, which looks bad.

When justify-content is set to normal, the modal title aligns to the modal content.

Issue fork socialbase-3314635

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

milos.kroulik created an issue. See original summary.

immaculatexavier’s picture

Status: Active » Needs review
FileSize
396 bytes

Attached patch for the stated requirement

milos.kroulik’s picture

Status: Needs review » Needs work

Thanks. I assume that we need to fix SCSS style as well. See https://git.drupalcode.org/project/socialbase/-/blob/2.1.x/components/04...

immaculatexavier’s picture

Status: Needs work » Needs review
FileSize
834 bytes
338 bytes

@milos.kroulik,
Addressed #3 and attached patch for the same.

milos.kroulik’s picture

The patch no longer applies. I'm trying to fix it, but it looks like there's an issue with the whitespace in modal.css file.

Agami4 made their first commit to this issue’s fork.

Agami4’s picture

Status: Needs review » Fixed
FileSize
45.31 KB

Thank you for your improvements to the modal window. The changes look good. I merged improvements into the 2.3.x branch and cherry-pick into the 2.4.x and 2.5.x branches.
fix

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.