Problem/Motivation
When users are not permitted to register for a new account, the "sign up link" area shows up as an empty grey card.
You may tread this as a "design feature", but at the end it makes it hard to implement other functionality like a persistent login for example in the same way:
Because you expect a result like:
The patch attached solves this issue. The result is a look like above, or with a sign up link (no change to current behaviour in this scenario):
Steps to reproduce
Limit registration for new accounts to admins only.
Go to the login page
Proposed resolution
Patch attached
User interface changes
Will only add the card formatting, when a sign up link exists
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
login_card.patch | 923 bytes | slowflyer | |
Image4.jpg | 50.65 KB | slowflyer | |
Image3.jpg | 45.09 KB | slowflyer | |
Image2.jpg | 44.49 KB | slowflyer | |
Image1.jpg | 41.42 KB | slowflyer |
Issue fork socialbase-3229966
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
Agami4 CreditAttribution: Agami4 as a volunteer and at Lemberg Solutions, Open Social, Drupal Ukraine Community for Open Social commentedHey Slowflyer, do you still working on this issue? Can I change status for `active` to `review`?
Comment #4
slowflyer CreditAttribution: slowflyer commentedYes, can be reviewed.
Comment #5
Agami4 CreditAttribution: Agami4 as a volunteer and at Lemberg Solutions, Open Social, Drupal Ukraine Community for Open Social commentedComment #8
ressinelComment #9
ressinelIt will be released in Social Base 2.1.5
Comment #10
ressinel