Problem/Motivation

When users are not permitted to register for a new account, the "sign up link" area shows up as an empty grey card.
Image1
You may tread this as a "design feature", but at the end it makes it hard to implement other functionality like a persistent login for example in the same way:
image 2
Because you expect a result like:
Image3

The patch attached solves this issue. The result is a look like above, or with a sign up link (no change to current behaviour in this scenario):
image 4

Steps to reproduce

Limit registration for new accounts to admins only.
Go to the login page

Proposed resolution

Patch attached

User interface changes

Will only add the card formatting, when a sign up link exists

API changes

Data model changes

CommentFileSizeAuthor
login_card.patch923 bytesslowflyer
Image4.jpg50.65 KBslowflyer
Image3.jpg45.09 KBslowflyer
Image2.jpg44.49 KBslowflyer
Image1.jpg41.42 KBslowflyer

Issue fork socialbase-3229966

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slowflyer created an issue. See original summary.

Agami4’s picture

Hey Slowflyer, do you still working on this issue? Can I change status for `active` to `review`?

slowflyer’s picture

Status: Active » Needs review

Yes, can be reviewed.

Agami4’s picture

Assigned: Unassigned » navneet0693

Ressinel made their first commit to this issue’s fork.

  • Ressinel committed 7d6a86a on 2.1.x authored by slowflyer
    Issue #3229966 by slowflyer, Ressinel: Empty Card on User Login form
    
ressinel’s picture

Status: Needs review » Reviewed & tested by the community
ressinel’s picture

Version: 1.3.x-dev » 2.1.x-dev

It will be released in Social Base 2.1.5

ressinel’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.