CommentFileSizeAuthor
#9 convert_block_system_to-2355003-9.patch2.5 KBSharique
#7 convert_block_system_to-2355003-7.patch2.51 KBSharique
#6 convert_block_system_to-2355003-6.patch2.5 KBSharique
#4 convert_block_system_to-2355003-4.patch2.37 KBSharique
#1 convert_block_system_to-2355003-1.patch1.92 KBSharique
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Active » Needs review
Issue tags: -SprintWeekend2013, -#drupalpune-sprint
FileSize
convert_block_system_to-2355003-1.patch1.92 KB

I've ported the block/ctool content type to new block system.
@todo Add configuration setting to block.

Status: Needs review » Needs work

The last submitted patch, 1: convert_block_system_to-2355003-1.patch, failed testing.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Needs work » Needs review

triggering test again.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
FileSize
convert_block_system_to-2355003-4.patch2.37 KB

Updated blockAccess method code to fix error.

Status: Needs review » Needs work

The last submitted patch, 4: convert_block_system_to-2355003-4.patch, failed testing.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Needs work » Needs review
FileSize
convert_block_system_to-2355003-6.patch2.5 KB

Blocks build function must always return array.
Disabling test we don't have valid tests.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
FileSize
convert_block_system_to-2355003-7.patch2.51 KB

Added missing return in blockAccess.

malcomio’s picture

malcomio CreditAttribution: malcomio at Capgemini commented 
+++ b/src/Plugin/Block/SocialStatsBlock.php
@@ -22,20 +24,46 @@ class SocialStatsBlock extends BlockBase {
+          '#markup' => $total . ' Shares',

the block markup should go through t()

also it would be good to use pluralization - not sure how it works in Drupal 8, but I think this is the relevant info: https://www.drupal.org/node/2173787

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
FileSize
convert_block_system_to-2355003-9.patch2.5 KB

Thanks Malcolm, here is updated patch.

Status: Needs review » Needs work

The last submitted patch, 9: convert_block_system_to-2355003-9.patch, failed testing.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Needs work » Needs review

Forgot to un-select tests.

  • Sharique committed d8ee577 on 8.x-1.x 
    Issue #2355003 by Sharique: Convert block system to new plugins
Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Needs review » Closed (fixed)
Parent issue: » #2107321: [meta] Drupal 8 port of Social Stats
Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.