Currently it is not possible to export Social Login settings either via Drupal config export or features. The settings saved in {oneall_social_login_settings} should be stored in Drupals config system instead. An update path would be required, to migrate existing settings from their own table to Drupals config storage.

CommentFileSizeAuthor
#16 interdiff_2753783-12-16.txt2.43 KBkeopx
#16 move-settings-to-configuration-2753783-16.patch12.27 KBkeopx
#12 move-settings-to-configuration-2753783-12.patch3.72 KBa.sotirov
#11 move-settings-to-configuration-2753783-11.patch3.74 KBa.sotirov
#10 move-settings-to-configuration-2753783-10.patch3.67 KBa.sotirov
#9 move-settings-to-configuration-2753783-5.patch3.64 KBdtv_rb
#4 move-settings-to-configuration-2753783-4.patch3.64 KBElegguaDP
#2 move-settings-to-configuration-2753783.patch4.31 KBsch4lly

Comments

sch4lly created an issue. See original summary.

sch4lly’s picture

sch4lly commented
Status: Active » Needs review
StatusFileSize
new move-settings-to-configuration-2753783.patch4.31 KB

Here's a patch.

jaxxed’s picture

jaxxed commented

question: does it make sense to put any default settings for the config into ./config/install/XXX.yml ?

ElegguaDP’s picture

ElegguaDP commented
StatusFileSize
new move-settings-to-configuration-2753783-4.patch3.64 KB

This is more correct patch because hook_install and hook_uninstall are removed from stable branch @see https://www.drupal.org/node/2759215

dtv_rb’s picture

dtv_rb commented

Patch works fine!

This should be merged to the module ASAP to prevent conflicts with future changes to the oneall settings table.

Also the update key 8001 could be overwritten/used in a future release, which would lead to these updates not being executed.

omar alahmed’s picture

omar alahmed
Primary language English
Location Jordan
commented

#4 works successfully with me but I think config/install and config/schema directories should be defined in the module root, with the default module config and schema.

dtv_rb’s picture

dtv_rb commented

#4 no longer works with the latest version of the module.

ClaudeSchlesser’s picture

ClaudeSchlesser commented
Status: Needs review » Postponed

Hello,

I will manually merge the patch into the next version!

Best Regards,

dtv_rb’s picture

dtv_rb commented
StatusFileSize
new move-settings-to-configuration-2753783-5.patch3.64 KB

This new patch can be used until the next version.

a.sotirov’s picture

a.sotirov commented
StatusFileSize
new move-settings-to-configuration-2753783-10.patch3.67 KB

Hello,
I have just created a patch for version 8.x-2.89. It would be good to consider implementing this functionality on the new stable release.

Best Regards,
Atanas Sotirov

a.sotirov’s picture

a.sotirov commented
StatusFileSize
new move-settings-to-configuration-2753783-11.patch3.74 KB

Here is the updated patch with \Drupal::database() service.

Best Regards,
Atanas Sotirov

a.sotirov’s picture

a.sotirov commented
StatusFileSize
new move-settings-to-configuration-2753783-12.patch3.72 KB

Fixed empty $connection->query() missed code.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Version: 8.x-1.1 » 8.x-2.89
Category: Feature request » Task
Status: Postponed » Needs work

I think that is important to work for the futur

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Status: Needs work » Reviewed & tested by the community

I tested patch #12

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Status: Reviewed & tested by the community » Needs work

Pending to resolve messenger dependencies on constructor...

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
StatusFileSize
new move-settings-to-configuration-2753783-16.patch12.27 KB
new interdiff_2753783-12-16.txt2.43 KB

Here reroll patch for Drupal 9 Support.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Status: Needs work » Needs review