Fix coding standards [#3101051]

I noticed that the following error is produced when checking for coding standard violations:

phpcs --standard=Drupal .

FILE: /var/www/html/drupal2/modules/custom/social_auth_paypal/src/Plugin/Network/PaypalAuth.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 37 | ERROR | [x] Data types in @throws tags need to be fully namespaced
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

Time: 155ms; Memory: 8MB

Comment	File	Size	Author
#19	After apply patch 3101051.png	91.38 KB	riddhi.addweb
#13	patch#10.png	142.82 KB	roberttabigue
#10	social_auth_paypal-fix-coding-standards-3101051-10.patch	2.17 KB	neel24
#8	social_auth_paypal-fix-coding-standards-3101051-8.patch	2.19 KB	neel24
#7	social_auth_paypal-fix-coding-standards-3101051-7.patch	2.25 KB	neel24
#2	social_auth_paypal-fix-coding-standards-3101051-2.patch	559 bytes	neel24

Issue fork social_auth_paypal-3101051

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3101051-fix-coding-standards changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

14 December 2019 at 18:55

neel24 created an issue. See original summary.

Status	File	Size
new	social_auth_paypal-fix-coding-standards-3101051-2.patch	559 bytes

Comment #3

neel24 commented 14 December 2019 at 18:58

Status:

Active

» Needs review

Comment #4

gvso

Spanish

commented 20 December 2019 at 07:14

Status:

Needs review

» Needs work

Opps. It seems like I included this change in #3013252: "Paypal" should be "PayPal". However, drupal coding practice throws

FILE: /var/www/drupal_projects/drupal_dev/modules/social_auth_paypal/src/PayPalAuthManager.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 33 | ERROR | The $_GET super global must not be accessed directly; inject the request.stack service and use
    |       | $stack->getCurrentRequest()->query->get('code') instead
---------------------------------------------------------------------------------------------------------------------------------------

Time: 127ms; Memory: 6MB

We should fix that! See Social Auth Google for an example!

Comment #5

neel24 commented 21 December 2019 at 14:55

Hmm, I cross-checked with Social Auth Google, and it seems that it also returns the same error:

phpcs --standard=DrupalPractice .

FILE: /var/www/html/drupal2/modules/social_auth_google/src/GoogleAuthManager.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 36 | ERROR | The $_GET super global must not be accessed directly; inject the request.stack
    |       | service and use $stack->getCurrentRequest()->query->get('code') instead
----------------------------------------------------------------------------------------------------

Time: 86ms; Memory: 6MB

Comment #6

gvso

Spanish

commented 24 December 2019 at 17:01

My bad. I thought it was fixed there. Ok, basically, you wanna inject the current request service into the constructor of that class. Then, you want to let Drupal know by adding it as a dependency in the .services.yml file. Let me know if you have any questions!

Comment #7

neel24 commented 31 December 2019 at 20:47

Status:

Needs work

» Needs review

Status	File	Size
new	social_auth_paypal-fix-coding-standards-3101051-7.patch	2.25 KB

Alright, so I had a look at Social Auth Heroku for ref and I've made some changes to fix the error.

Comment #8

neel24 commented 1 January 2020 at 21:30

Status	File	Size
new	social_auth_paypal-fix-coding-standards-3101051-8.patch	2.19 KB

Sorry, had forgotten to remove var_dump. Attaching new patch.

Comment #9

agrochal commented 26 January 2020 at 16:23

Status:

Needs review

» Needs work

You use the wrong way to implement request service inside construct function, check this issue: https://www.drupal.org/project/social_auth_google/issues/3109038

Comment #10

neel24 commented 29 January 2020 at 18:38

Status:

Needs work

» Needs review

Status	File	Size
new	social_auth_paypal-fix-coding-standards-3101051-10.patch	2.17 KB

My bad, the OAuth2Manager in Social Api had been updated and I was still using an older version, hence that's why the previous request was still working for me. I've updated the patch to fix the coding standards and updated the request.

Comment #11

16 September 2022 at 05:19

samir_shukla made their first commit to this issue’s fork.

Comment #12

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 6 July 2023 at 10:25

Issue tags:

+Coding standards

Comment #13

roberttabigue commented 19 July 2024 at 17:56

Status:

Needs review

» Needs work

Status	File	Size
new	patch#10.png	142.82 KB

Hi @neel24,

Your patch#10 is not working on the 'Social Auth PayPal' module against 8.x-2.x-dev on my D10 site.

I ran this command on the module:
curl https://www.drupal.org/files/issues/2020-01-29/social_auth_paypal-fix-coding-standards-3101051-10.patch | git apply -v

Please see the attached file for reference.

I'm moving this to ‘Needs work’ for now.

Thank you!