Add animation to Social Auth icons in Social Auth block on hover [#2945536]

Comment	File	Size	Author
#10	interdiff-5-9.txt	1.24 KB	MaskyS
#9	hover-animation-9.patch	675 bytes	MaskyS

#6	hover-animation-5.patch	1.42 KB	MaskyS

#3	Add-animation-to-Social-Auth-icons-2945536-2.patch	679 bytes	ankitjain28may

Comment #1

17 February 2018 at 13:37

MaskyS created an issue. See original summary.

Log in or register to post comments

Comment #2

ankitjain28may CreditAttribution: ankitjain28may commented 23 February 2018 at 19:46

I would like to work on this feature.
Do you have any image file like this "http://demo.zymphonies.com/free-theme/blogon-responsive-theme/index/site..." so i will make it animate as you required ?

Log in or register to post comments

Comment #3

ankitjain28may CreditAttribution: ankitjain28may commented 23 February 2018 at 21:22

Status:

Active

» Needs review

File	Size
Add-animation-to-Social-Auth-icons-2945536-2.patch	679 bytes

I have tried to animate the Auth icons but these are not as similar as in the demo.

Log in or register to post comments

Comment #4

MaskyS CreditAttribution: MaskyS commented 23 February 2018 at 22:01

Status:

Needs review

» Needs work

Good job, but the grey does not persist while the cursor is hovering on the logo. i.e it returns back to coloured version once the animation has ended. Can we fix that?

Log in or register to post comments

Comment #5

ankitjain28may CreditAttribution: ankitjain28may commented 23 February 2018 at 22:04

Ok, Yes, It can be done.

Log in or register to post comments

Comment #6

MaskyS CreditAttribution: MaskyS commented 23 February 2018 at 22:11

File	Size
hover-animation-5.patch	1.42 KB

Well, added a line to deal with it. Let's see what other maintainers think of this.

Log in or register to post comments

Comment #7

MaskyS CreditAttribution: MaskyS commented 23 February 2018 at 22:11

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #8

dbjpanda CreditAttribution: dbjpanda commented 9 March 2018 at 18:46

#6

+++ b/css/auth-icons.css
@@ -7,4 +7,27 @@
+    filter: grayscale(1);  ¶

Just a nitpick. Remove the whitespace at the end.

Log in or register to post comments

Comment #9

MaskyS CreditAttribution: MaskyS commented 25 February 2018 at 10:59

File	Size
hover-animation-9.patch	675 bytes

Good catch. There was also an unrelated fix in the .install file. We should be good now.

Log in or register to post comments

Comment #10

MaskyS CreditAttribution: MaskyS commented 25 February 2018 at 11:02

File	Size
interdiff-5-9.txt	1.24 KB

Attaching interdiff.

Log in or register to post comments

Comment #12

gvso

Spanish

CreditAttribution: gvso at Google Code-In, Google Summer of Code commented 3 March 2018 at 18:34

Status:

Needs review

» Fixed

Thanks!

+++ b/css/auth-icons.css
@@ -7,4 +7,26 @@
+@keyframes grey {
+  from {
+    webkit-filter: grayscale(0);
+    filter: grayscale(0);
+  }
+  to {
+    webkit-filter: grayscale(1);
+    filter: grayscale(1);
+  }

There was a missing curly bracket here!

Log in or register to post comments

Comment #13

ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commented 3 March 2018 at 18:45

Thanks :)

Log in or register to post comments

Comment #14

ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commented 9 March 2018 at 18:55

@gvso Should i get the credit for this as i have submitted the first patch ( https://www.drupal.org/files/issues/Add-animation-to-Social-Auth-icons-2945536-2.patch). Did i submit the wrong patch ?

Log in or register to post comments

Comment #15

gvso

Spanish

CreditAttribution: gvso at Google Code-In, Google Summer of Code commented 10 March 2018 at 00:24

@ankitjain28may, for some reason, your patch doesn't appear in this issue. Are you sure you uploaded it in the correct issue? Drupal.org didn't put your name in the commit message example for a reason.

Log in or register to post comments

Comment #16

MaskyS CreditAttribution: MaskyS commented 10 March 2018 at 08:57

@gvso, I can see his patch though.. https://screenshots.firefox.com/RJ7XMk6MFkyPjCyQ/www.drupal.org

Log in or register to post comments

Comment #17

ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commented 10 March 2018 at 09:38

@gvso My comment was not visible because my account was not confirmed at the time of patch submission.

Log in or register to post comments

Comment #18

gvso

Spanish

CreditAttribution: gvso at Google Code-In, Google Summer of Code commented 11 March 2018 at 00:34

Sorry, I didn't even see that patch nor your username in this issue. That's why I didn't add you in the commit message.

Log in or register to post comments

Comment #19

ankitjain28may CreditAttribution: ankitjain28may as a volunteer and at Google Summer of Code commented 12 March 2018 at 11:21

@gvso Ok so is there anything that can be possible now ?

Log in or register to post comments

Comment #20

gvso

Spanish

CreditAttribution: gvso at Google Code-In, Google Summer of Code commented 12 March 2018 at 22:46

Well, you can work on issues that requires small changes such as #2947737: Implement new methods in OAuthManager

Log in or register to post comments

Comment #21

dbjpanda CreditAttribution: dbjpanda commented 13 March 2018 at 17:59

@ankitjain28may Seems like you have been fighting for the credit from the first day. :) Well you should concentrate on more issue.
@gvso I can also see the patch here https://www.drupal.org/files/issues/Add-animation-to-Social-Auth-icons-2... so you can revert the commit with a new commit message and a credit to @ankitjain28may . Lets welcome and encourage them to contribute more. Cheers.