In a future version of Address the dependency to the Zone library will be removed. Let's not check for this Class anymore in the installation requirements. Also we can assume that if someone installed the CommerceGuys/Addressing library the necessary dependencies are also installed.

Proposal:

  • Remove requirements check for dependencies of the addressing libraries
  • Only keep one requirement check for the addressing library itself

Code change:

https://github.com/goalgorilla/open_social/pull/391

Comments

jaapjan created an issue. See original summary.

jaapjan’s picture

jaapjan CreditAttribution: jaapjan at Open Social commented
Issue summary: View changes
frankgraave’s picture

frankgraave CreditAttribution: frankgraave for Open Social commented
Status: Active » Reviewed & tested by the community

Hi JaapJan,

This will be in the next release, PR is merged. PR: https://github.com/goalgorilla/open_social/pull/391

Frank

jaapjan’s picture

jaapjan CreditAttribution: jaapjan at Open Social commented
Status: Reviewed & tested by the community » Fixed

  • jaapjan committed 725021b on 8.x-1.x 
    Issue #2882966 by jaapjan: remove (soon to be) obsolete Address...
  • frankgraave authored a7ae879 on 8.x-1.x
    Merge pull request #391 from goalgorilla/2882966-address

#2882966:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.