I updated SMTP module from 7.x.1.4 to 7.x.1.6 version
But when you receive a e-mail, the address from the sender is now replaced by the site name information.

CommentFileSizeAuthor
#10 smtp_authentication_fromfix.patch402 bytespub497
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vcouver created an issue. See original summary.

vcouver’s picture

Title: Adress from the sender is now replaced by the site name information. » 7.x-1.6 Adress from the sender is now replaced by the site name information.
vcouver’s picture

Issue summary: View changes
vcouver’s picture

Title: 7.x-1.6 Adress from the sender is now replaced by the site name information. » 7.x-1.6 Address from the sender is now replaced by the site name information.
vcouver’s picture

vcouver’s picture

When I look at my message list in the Inbox,
the header information is shown with the address mail from the sender, with SMTP 7.x-1.4.
That"s OK for me.
But with SMTP 7.x-1.6, the name of the "system administration site" replaces now the address.
Could you please tell me why ?

How can I retreive and see my address in the list ?

PS : When the message is opened, the address of the sender is OK , in SMTP 7.x-1.4 and SMTP 7.x-1.6

drupal 7.53
php 7
mysql 5.0.12-dev

vcouver’s picture

I found.
It's in this file : /sites/all/modules/smtp.mail.inc
and "$properfrom" value

SMTP 7.x-1.6 line 136: $properfrom = variable_get('smtp_from', '');
SMTP 7.x-1.4 line 122: $properfrom = variable_get('site_mail', '');

monstrfolk’s picture

Same problem on 7.x-2.x-dev.

pub497’s picture

This is an issue for me as well, going from 1.3->1.6

when using drupal_mail('modulename','key', $to, language_default(), $params, $from) the $from address is never used in the mail, the resulting mail always has the site default email in there

edit:

removing line 140 ($from = $properfrom;) fixed my issue, not sure why $from is being replaced here anyways, that line basically meant the $from that's passed in will always be replaced by 'smtp_from'

pub497’s picture

Here it is with that line removed

tclnj’s picture

Exists in 7.x-1.7 as well.

I just commented out lines 136-140 in smtp.mail.inc

// $properfrom = variable_get('smtp_from', '');
// if (!empty($properfrom)) {
// $headers['From'] = $properfrom;
// $from = $properfrom;
// }