Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Deprecated function: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in Drupal\smtp\PHPMailer\PHPMailer->EncodeQ() (line 1762 of modules/contrib/smtp/src/PHPMailer/PHPMailer.php).
Settings:
smtp_on: true
smtp_host: smtp.xyz.de
smtp_hostbackup: ''
smtp_port: '25'
smtp_protocol: standard
smtp_username: foobar@domain.de
smtp_password: 1234567890
smtp_from: no-reply@domain.de
smtp_fromname: 'My Name'
smtp_allowhtml: '1'
smtp_test_address: ''
smtp_debugging: false
prev_mail_system: php_mail
_core:
default_config_hash: xyz
langcode: de| Comment | File | Size | Author |
|---|---|---|---|
| #20 | smtp-2729143-20.patch | 1.36 KB | pifagor |
| #8 | smtp-2729143-8.patch | 1.36 KB | pifagor |
| #5 | screen_027.png | 20.73 KB | abogomolov |
| #2 | smtp-2729143-2.patch | 1.49 KB | pifagor |
Comments
Comment #2
pifagorAdd patch
Comment #3
pifagorComment #4
pifagorComment #5
abogomolov CreditAttribution: abogomolov commentedI have some PHP code in the subject now. See screen.
Comment #6
pifagorwrite more as to reproduce this bug?
Comment #7
pifagorComment #8
pifagorTest @abogomolov please. Everything should work
Comment #9
asrobI've successfully applied this patch and works fine. Change its status to RTBC.
Comment #10
DamienMcKennaDoes it still need tests?
Comment #11
pifagoreverything works, transport needs
Comment #12
abogomolov CreditAttribution: abogomolov commentedI can only agree with that. Patch #8 works.
@pifagor Thank you!
Comment #13
Eric_A CreditAttribution: Eric_A commentedI've removed the "requires transfer" tag from both this issue and #2708101: Default value for link text is not saved.
@pifagor, please see the Issue tags description text. We're not supposed to create new tags.
Comment #14
Eric_A CreditAttribution: Eric_A commentedComment #15
Eric_A CreditAttribution: Eric_A commentedIs this issue hacking external library code that is shipped with this Drupal project? What is the current state of the shipped build? Is it already forked in this project?
Comment #16
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedThe patch from #8 looks fine. It is fixed the problem, but leaved 'todo' comment.
My patch fixes this.
@Eric_A, the answer is yes, currently module ships own version 5.1 of external library, and patches hacking it.
More modern approach is already scheduled as a task in this issue [2711559].
I believe current fix is good to be committed before PHPMailer is not used via Composer.
Comment #17
pifagor@dpovshed, thank you for your feedback. But your patch, a copy of the patch #2, which is not working. A patch #8 working and 'todo' comment is present.
Comment #18
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented@pifagor, thanks for the feedback! you're right, I took the wrong patch!
Maybe you want to extend your #8 by yourself? Only one additional line shoudl be deleted.
Comment #19
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedComment #20
pifagor@dpovshed Comments into account and corrected patch
Comment #21
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedPatch from #20 looks perfect, I think it is ready to commit.
Comment #22
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedComment #24
wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commentedComment #26
pifagor