function sms_twilio_send($number, $message, $options) {
  $number = preg_replace("/[^0-9\+]/", '', $number);
  $number = trim($number);
  $number = ltrim($number, '0'); // Remove leading zeros
  if (isset($options['country'])) {
        if ($options['country']=='00')  // international prefix
                $number='00'.$number;
        else
                {       // -1 or something else
                $index = strpos($number, $options['country']);
                if ($index === FALSE || $index > 0) {
                        $number = '00'.$options['country'] . $number;
                }
    }
  }
  return sms_twilio_command('sendmsg', array('number' => $number, 'message' => $message), NULL, NULL);
}

Comments

arne_hortell created an issue. See original summary.

arne_hortell’s picture

arne_hortell commented
Issue summary: View changes
arne_hortell’s picture

arne_hortell commented
Issue summary: View changes
chrisrockwell’s picture

chrisrockwell commented

@arne_hortell Thank you for filing an issue, sorry for the delay but I'm not getting notified when an issue is posted - I'll look into that.

As someone that's never used international numbers, can you give me more information on how what you'd expect to happen and what is actually happening?

Looking at how Clickatell implements this, I'm wondering if that implementation would solve the problem?

chrisrockwell’s picture

chrisrockwell commented

@arne_hortell I think this is related to #1837754: Does not work with non north american phone numbers. Would you be willing to test that solution and see if it works for you? The only reason I haven't committed it yet is I'm just not up-to-date on International numbers.

arne_hortell’s picture

arne_hortell commented

Yes it is related as all numbers starting with +1 is either american or canadian and im swedish +46...

bildesbil’s picture

bildesbil commented

Hello,
I have a little problem with the module sms framework on drupal I would like to know if you can help me!
I use the module with the twilio sms integration module. I have an error every time I try to send an SMS via my drupal site using the twilio gateway.

The framework removes the "+" from the international number and this generates an error in the twilio library. Saying that the number is valid.

I do not know if you can help me solve my problem

Best regards.

chrisrockwell’s picture

chrisrockwell commented

Sorry for the delay in this, I'll take a look at this and the other linked issue before the end of this week.

chrisrockwell’s picture

chrisrockwell commented
Status: Active » Closed (duplicate)

I committed the patch from the issue to 1.x and 2.x