Hi, I thought I could use smart_trim to add trimming functionality to plain text fields. On the surface it *seems* trivial enough and I have supplied a patch. A few notes: I wrote this patch against 8.x-1.0 which is what my site is using during it's build. While writing a patch I saw that there was significant work in 8.x-dev so I copied it down and did some quick testing.

This visually is working for me using both branches but I suspect there are greater concerns with validation and I probably have not considered all the differences between the field types.

In short I propose something along these lines, and if we think this is a good use case/functionality. I can work on getting a proper patch in.

CommentFileSizeAuthor
#2 smart_titles-plaintext-functionality-2842783-2-D8.patch1 KBrichard.c.allen2386
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

richard.c.allen2386 created an issue. See original summary.

richard.c.allen2386’s picture

richard.c.allen2386 CreditAttribution: richard.c.allen2386 at Bixal commented
FileSize
smart_titles-plaintext-functionality-2842783-2-D8.patch1 KB
richard.c.allen2386’s picture

richard.c.allen2386 CreditAttribution: richard.c.allen2386 at Bixal commented
Status: Active » Needs review
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented

Patch works for 8.x-1.0, thanks!

markie’s picture

markie CreditAttribution: markie at Mediacurrent commented
Status: Needs review » Fixed

Patch applies cleanly against dev branch and works as expected. Thanks for your help, I'll try to get a full release out soon.

PhilY’s picture

PhilY
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
CreditAttribution: PhilY commented

Patch from comment #2 works fine with Drupal 8.2.6 and Smart Trim 8.x-1.0
Many thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.