Characters being converted by linking content [#2507161]

It looks as though when using this module, if you are using the link ability, it is converting characters to their htmlentity code.

Example: In the body if you have "><&<><&" it would print as "><&<><&"

To Test:

In a content type display, select "smart trim" as the formatter.
Select to link the content.
Save the content display mode.
Create a piece of content with "><&<><&"
View the display mode and the content should be escaped properly.

To solve. I believe we just need to add array('html'=>TRUE), to the final link.

Comment	File	Size	Author
#10	interdiff.txt	3.54 KB	anfor
#10	smart_trim-7.x-1.x-html-with-content-link-2507161-10.patch	4.23 KB	anfor
#6	smart_trim-7.x-1.5-html-with-content-link-2507161-6.patch	3.87 KB	anfor
#6	smart_trim-7.x-1.x-html-with-content-link-2507161-6.patch	3.87 KB	anfor
#1	smart_trim-no_escape_html_entities-2507161-1.patch	645 bytes	timodwhit

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

timodwhit CreditAttribution: timodwhit commented 16 June 2015 at 21:53

File	Size
smart_trim-no_escape_html_entities-2507161-1.patch	645 bytes

Comment #2

timodwhit CreditAttribution: timodwhit commented 16 June 2015 at 21:54

Issue summary:

View changes

Comment #3

timodwhit CreditAttribution: timodwhit commented 16 June 2015 at 22:20

Status:

Active

» Needs review

Comment #4

timodwhit CreditAttribution: timodwhit commented 17 June 2015 at 16:23

Issue summary:

View changes

Comment #5

rymcveigh

he/him/his

CreditAttribution: rymcveigh commented 17 June 2015 at 16:31

Status:

Needs review

» Reviewed & tested by the community

I tested this patch with simplytestme. Works great. Super simple fix that is good to go.

Comment #6

anfor CreditAttribution: anfor commented 13 August 2015 at 08:51

Status:

Reviewed & tested by the community

» Needs review

File	Size
smart_trim-7.x-1.x-html-with-content-link-2507161-6.patch	3.87 KB
smart_trim-7.x-1.5-html-with-content-link-2507161-6.patch	3.87 KB

Since these characters are detected as HTML tags, isn't better to allow HTML tags using "Tags to preserve" settings ?
See my patch for dev version and stable version as well.

Comment #7

j2r CreditAttribution: j2r commented 14 April 2016 at 01:06

Added patch there for allowing html in more link -> https://www.drupal.org/node/2483401

Comment #8

icampana

Spanish

CreditAttribution: icampana at Domo Soluciones Web & TI commented 8 February 2017 at 06:39

I can confirm that patch at #6 solved the issue and didn't cause any trouble

Comment #9

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 23 January 2019 at 04:38

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

The 3 year old patch in #6 to smart_trim.module does not apply to the latest smart_trim 7.x-1.x-dev and needs to be re-rolled.

Checking patch smart_trim.module...
error: while searching for:
        }

        // Process additional options (currently only HTML on/off)
        if (!empty($settings['trim_options'])) {
          if (!empty($settings['trim_options']['text'])) {
            // Strip tags
            $preserve_tags = !empty($settings['trim_preserve_tags']) ? $settings['trim_preserve_tags'] : '';
            $output = strip_tags(str_replace('<', ' <', $output), $preserve_tags);

            // Strip out line breaks

error: patch failed: smart_trim.module:53
error: smart_trim.module: patch does not apply