Problem/Motivation

The smartdate_custom format has no complete schema definition.

Steps to reproduce

Use the smartdate_custom format in a display.

Proposed resolution

Complete the schema.

Issue fork smart_date-3491083

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joshahubbers created an issue. See original summary.

joshahubbers opened merge request !162

dhruv.mittal’s picture

dhruv.mittal commented
Status: Active » Reviewed & tested by the community

I have applied the patch it works fine for me so moving it to the RTBC
Thanks !!

stefan.korn made their first commit to this issue’s fork.

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
Status: Reviewed & tested by the community » Needs review

It's true that schema defintion for smartdate_custom formatter is not valid. Drupal 11.2 LenientConfigSchemaChecker is complaining.

But seems to me the schema definition for the smartdate_custom formatter from this MR could be reduced by using the config from the core timestamp formatter from which smartdate_custon is inheriting.

I am not exactly sure if all the "label" types are required in the schema. I believe label types would be relevant if the config setting should be translatable?

I have updated the MR. LenientConfigSchemaChecker is not complaining anymore now, but MR should be reviewed regarding the types of the config options.