Problem/Motivation

ESLint reports a total of 261 errors. The full list can be seen here: https://git.drupalcode.org/issue/smart_date-3433051/-/jobs/1140097

Fixing that many errors in one issue would be difficult to review, so I suggest fixing one type of error at a time.

Steps to reproduce

Open GitLab in browser and view latest pipeline.

Proposed resolution

To make reviewing as easy as possible, I propose fixing errors of type "Identifier '_____' is not in camel case" in this issue.

Other errors can be fixed in follow on issues.

As JavaScript errors do not overlap with PHP problems, they can be worked on at the same time.

Remaining tasks

Related issue #3433051: Add Gitlab CI needs to be merged first.

Then all snake case variables in JavaScript files should be converted to camel case.

When all JavaScript errors have been resolved, the eslint tests can be set to require passing.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork smart_date-3433215

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lostcarpark created an issue. See original summary.

lostcarpark’s picture

lostcarpark commented
Issue summary: View changes

lostcarpark opened merge request !92

lostcarpark’s picture

lostcarpark commented

This issue reducces the total number of eslint problems from 261 to 134:

134 problems (95 errors, 39 warnings)

This only deals with camel case issues in the JS files, which should make it easy to review.

It does include some minor indentation problems in YML files, which are also reported by eslint. I felt these were minor enough, and in separate files from the camel case problems, so could be included in the same issue.

lostcarpark’s picture

lostcarpark commented
Status: Active » Needs review

Setting to needs review.

Additional issues will be created for further eslint problems.

mandclu made their first commit to this issue’s fork.

mandclu’s picture

mandclu commented
Status: Needs review » Fixed

Thanks for your work on this @lostcarpark. I have manually tested various Javascript-driven behaviour after applying these changes, and everything seems to work as before. Merged in.

lostcarpark’s picture

lostcarpark commented

Actually I misrepresented the number of errors. Eslint runs twice with different parameters, and the first run returns the bigger number of errors.

Before this change, the number of errors was:

555 problems (512 errors, 43 warnings)

After, its:

385 problems (342 errors, 43 warnings)

So a solid step in the right direction, but quite a lot to do!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.