Problem/Motivation

onboard Gitlab CI!

Issue fork smart_date-3433051

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

BenStallings created an issue. See original summary.

BenStallings opened merge request !88

benstallings’s picture

benstallings commented
Status: Active » Needs review
benstallings’s picture

benstallings commented
Status: Needs review » Needs work
Issue tags: +MidCamp 2024

mandclu made their first commit to this issue’s fork.

mandclu’s picture

mandclu commented
Status: Needs work » Needs review

@BenStallings thanks for getting this issue created, and for your work on it. I was able to get the errors resolved, and am working on the deprecation warnings. I not sure the specifics of why you set this to Needs Work, but if you can give the revised MR a fresh look, maybe we can get this merged in.

lostcarpark made their first commit to this issue’s fork.

lostcarpark’s picture

lostcarpark commented

I've added back the "previous major" test. I added sections for the composer and phpunit tests for previous major to explicitly set the PHP version. These should be removed after Drupal 11 becomes current.

lostcarpark’s picture

lostcarpark commented
Status: Needs review » Reviewed & tested by the community

Moving to RTBC, also creating some follow on issues.

mandclu’s picture

mandclu commented
Status: Reviewed & tested by the community » Fixed

@lostcarpark thanks very much for your work on this. I've merged this in.

I see that you've also created issues for linting errors being thrown by Gitlab CI, I'll get on those next.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.