Problem/Motivation

During the running cron after the Drupal 10 upgrade I've got the error
Call to a member function toArray() on bool in Drupal\smart_date_recur\Plugin\QueueWorker\RecurRuleUpdate->processItem()
Sometimes this $rule->getNewInstances() returns FALSE and we need to process that case.

CommentFileSizeAuthor
#4 smart_date-cron_error-3399016-4.patch885 bytesmandclu
#2 smart_date_recur-call-function-toArray-on-bool-3399016.patch973 bytesgena.io

Comments

gena.io created an issue. See original summary.

gena.io’s picture

gena.io commented
StatusFileSize
new smart_date_recur-call-function-toArray-on-bool-3399016.patch973 bytes
gena.io’s picture

gena.io commented
Status: Active » Needs review
mandclu’s picture

mandclu commented
StatusFileSize
new smart_date-cron_error-3399016-4.patch885 bytes

Thanks for raising this, and for submitting a patch. I think we can resolve the error without needing to call makeRuleInstances() an extra time. Please test this updated patch.

gena.io’s picture

gena.io commented

Hi @mandclu
I can confirm that your patch is working, a good one with new PHP 8 features:)

gena.io’s picture

gena.io commented
Status: Needs review » Reviewed & tested by the community

  • mandclu committed d2bad5f6 on 4.1.x 
    Issue #3399016 by gena.io, mandclu: Call to a member function toArray()...
mandclu’s picture

mandclu commented
Status: Reviewed & tested by the community » Fixed

Thanks for the feedback, merged this fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.