Smart Date Range: Duration of >=16 years throws WSOD

@mandclu. Yes. That updated the date fields.

This is explicitly about the duration field, which I believe maxes out at signed mediumint.

Here's the DB table post 4.1.0-rc2 update:

mysql> describe node__field_rights_window;
+---------------------------------+--------------+------+-----+---------+-------+
| Field                           | Type         | Null | Key | Default | Extra |
+---------------------------------+--------------+------+-----+---------+-------+
| bundle                          | varchar(128) | NO   | MUL |         |       |
| deleted                         | tinyint      | NO   | PRI | 0       |       |
| entity_id                       | int unsigned | NO   | PRI | NULL    |       |
| revision_id                     | int unsigned | NO   | MUL | NULL    |       |
| langcode                        | varchar(32)  | NO   | PRI |         |       |
| delta                           | int unsigned | NO   | PRI | NULL    |       |
| field_rights_window_value       | bigint       | YES  | MUL | NULL    |       |
| field_rights_window_end_value   | bigint       | YES  | MUL | NULL    |       |
| field_rights_window_duration    | mediumint    | YES  |     | NULL    |       |
| field_rights_window_rrule       | int          | YES  | MUL | NULL    |       |
| field_rights_window_rrule_index | int          | YES  | MUL | NULL    |       |
| field_rights_window_timezone    | varchar(32)  | YES  |     | NULL    |       |
+---------------------------------+--------------+------+-----+---------+-------+
12 rows in set (0.00 sec)

Note field_rights_window_duration is still a mediumint.

> Why do you need to store events with such large durations?

In this case, it's genuinely an 18 year date range, just negotiated up from a 14 year date range. The client wants to store the date range for which rights have been granted for a particular media object, and wants to store that date range authoritatively (not fake it and say the rights started today).

I dunno, copyright licensing is weird.

Regardless of the duration, the module should throw an error on validation rather than WSOD on an invalid SQL insertion, regardless of the data being entered into the UI.

Something's not quite right about that math. I swear the duration data is in minutes, not seconds. Signed mediumint is 2^23 = 8.38M minutes = 15.9 years, and the system fails on 16 years but works on 14 years.

So a signed integer (2^31 minutes) would be 4085 years.

(If duration isn't minutes but seconds, something else odd is going on)

Honestly, I think it's more important to put in validation on the date range field to prevent a WSOD.

I see WSOD, I open a ticket. No judgement on how fast it gets fixed.

Either 1 ticket or two works for me. I see the justification for both, but if they're two separate commits, they'll definitely need to be sequenced.

Just some context - after a bit more investigation my client was trying to enter in a digital rights window of 99 years, apparently quite common in legal contexts.

https://en.wikipedia.org/wiki/99-year_lease

In history, 99 years was initially a placeholder for "forever" but apparently as the century passed, the law got kind of prickly about being literally 99 years and now it's commonplace.

This is in a field where rights windows are quite frequently just a few weeks, but they want to be able to use the field the same way for both instances.