FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\smart_date\modules\smart_date_recur\src\Controller\Instances.php
--------------------------------------------------------------------------------------------------------------------
101 | WARNING | Unused variable $entity.
--------------------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\smart_date\smart_date.install
---------------------------------------------------------------------------------
83 | WARNING | Unused variable $query.
---------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\smart_date\src\Commands\SmartDateDrushCommands.php
------------------------------------------------------------------------------------------------------
199 | WARNING | Unused variable $result.
------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\smart_date\src\SmartDateTrait.php
-------------------------------------------------------------------------------------
639 | WARNING | Unused variable $year_pos.
642 | WARNING | Unused variable $year_pos.
-------------------------------------------------------------------------------------

CommentFileSizeAuthor
#7 interdiff-3370893-2_7.txt417 bytesanchal_gupta
#7 3370893-7.patch1.94 KBanchal_gupta
#3 after-patch-3370893.png166.2 KBchandrashekhar_srijan
#2 3370893-2.patch1.53 KBarti_parmar

Comments

arti_parmar created an issue. See original summary.

arti_parmar’s picture

arti_parmar commented
Assigned: arti_parmar » Unassigned
Status: Active » Needs review
StatusFileSize
new 3370893-2.patch1.53 KB

Kindly review patch.

chandrashekhar_srijan’s picture

chandrashekhar_srijan commented
Status: Needs review » Needs work
StatusFileSize
new after-patch-3370893.png166.2 KB

Hi,
I have reviewed the patch #2. Still Unused variable $year_pos is showing. It needs to be removed.

 640 | WARNING | [ ] Unused variable $year_pos.
 643 | WARNING | [ ] Unused variable $year_pos.
anchal_gupta’s picture

anchal_gupta commented
Assigned: Unassigned » anchal_gupta
anchal_gupta’s picture

anchal_gupta commented
anchal_gupta’s picture

anchal_gupta commented
Assigned: anchal_gupta » Unassigned
anchal_gupta’s picture

anchal_gupta commented
Status: Needs work » Needs review
StatusFileSize
new 3370893-7.patch1.94 KB
new interdiff-3370893-2_7.txt417 bytes

I have to fix unused variables and upload the patch. Please review

indrapatil’s picture

indrapatil commented
Status: Needs review » Reviewed & tested by the community

The patch is working well so moving to RTBC.

  • mandclu committed 1e0097ab on 4.0.x 
    Issue #3370893 by Anchal_gupta, arti_parmar, mandclu: Unused variable $...
mandclu’s picture

mandclu commented
Status: Reviewed & tested by the community » Fixed

The extra $year_pos had already been resolved so I ended up applying the remaining changes by hand, only afterwards realizing this is effectively the set of changes from the patch in #2. Merged in. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.