Problem/Motivation

Clean up a litany of code standards issues (mostly warnings) that crept in over years of patches and other changes.

Comments

mandclu created an issue. See original summary.

  • mandclu committed f5314e9 on 3.5.x 
    Issue #3258815 by mandclu: Code Standards Fixes
mandclu’s picture

mandclu commented
Status: Active » Fixed

There are still some issues in the DataType plugin and a number of warnings about t() and \Drupal calls, but this is sizeable step in the right direction.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented
Priority: Normal » Critical
Status: Fixed » Needs work

The changes introduced by this commit in \Drupal\smart_date\Commands\SmartDateDrushCommands (lines 27-28 and 41-50, see GitLab) break all Drush commands on my installation:

$ drush st
                                                         
  Cannot add a required argument after an optional one.

With the help of drush st -vvv I was able to trace this down to the SmartDate command file. Manually reverting the changes in SmartDateDrushCommands.php fixed the problem for me. I am marking this as critical because it leaves Drush completely broken.

I'm using Drush 10.6.2 and PHP 8.0.14. Please let me know if you need more information to reproduce/fix this.

  • mandclu committed dadfff0 on 3.5.x 
    Issue #3258815 by mandclu, marcvangend: Code Standards Fixes

  • mandclu committed e7a731c on 3.5.x 
    Issue #3258815 by mandclu, marcvangend: Code Standards Fixes
marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented
Status: Needs work » Fixed

Thanks for the quick response. This fixes the problem.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.