PHP 7.3 Warning : "continue" targeting switch is equivalent to "break" [#3128140]

Devel Error

( ! ) Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /home/user/public_html/sites/all/modules/contrib/slick/slick_ui/plugins/export_ui/SlickUi.class.php on line 336

Seems this is an issue with PHP 7.3. I don't see any regressions, just a warning from Devel.

Comment	File	Size	Author
#7	3128140-7.patch	582 bytes	Jacqui.Tenderwolf
#7

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

16 April 2020 at 08:47

philsward created an issue. See original summary.

Comment #2

gausarts CreditAttribution: gausarts commented 16 April 2020 at 08:55

You are right. Thank you.

I remembered I had fixed it, but not all branches.

What is yours? That class is not 8.x.

Comment #3

philsward CreditAttribution: philsward commented 16 April 2020 at 08:59

Using ‘continue 2’ is very different than using ‘continue’. If it was coded using continue, it should be left as continue until the developer decides what it should actually be changed to – it could be ‘break’ or it could be ‘continue 2’. If you get the wrong one, the logic will change and the site could break in unexpected ways.

Changing line 336 from continue; to continue 2; made the errors go away. Dunno if this is right or not, but it makes devel shut up.

On a side note, I was getting the errors on a "views" page that had nothing to do with actually using slick. Is the Slick code being called on in places where it shouldn't be? Over my head.

Comment #4

philsward CreditAttribution: philsward commented 16 April 2020 at 09:00

7.x-2.1

Did I seriously set that to 8.x-2.x?? If I did, go ahead and change it if you need to. I could have sworn I changed it to 7.x-2.x

Comment #5

gausarts CreditAttribution: gausarts commented 16 April 2020 at 09:04

Spooky. If you didn't, who did? Check out your room for any astral intruder.

Patches are welcome.

Comment #6

gausarts CreditAttribution: gausarts commented 2 May 2020 at 11:34

Version:

8.x-2.x-dev

» 7.x-2.x-dev

Comment #7

Jacqui.Tenderwolf CreditAttribution: Jacqui.Tenderwolf at Interpersonal Frequency commented 17 August 2020 at 17:33

Version:	7.x-2.x-dev	» 7.x-2.1
Status:	Active	» Fixed

File	Size
3128140-7.patch	582 bytes

It looks like this has already been fixed in 7.x-2.x (thank you), but for those who want to keep running the 7.x-2.1 release, here is a patch. Marking issue as fixed.