Hi,
I run my site exclusively over HTTPS. I realised the module calls http://www.skypeassets.com/i/scom/js/skype-uri.js over HTTP (hardcoded). Therefore my browser blocks the call because of mixed content.

I'd suggest doing one of the following:

  1. Always load the file over HTTPS (change URL to https://secure.skypeassets.com/i/scom/js/skype-uri.js)
  2. Check for the protocol in use by the site and use the appropriate URL.

IMHO I'd simply go for option 1 above.

Thanks for a little great module.
Regards,
Luca

Comments

jaxtheking created an issue. See original summary.

rv0’s picture

rv0 commented

You generally just use protocol-independant calls in drupal_add_js / attach code. So normally just the "http:" part should be removed.
However, that doesn't work

You'll get an error:
https://www.skypeassets.com/i/scom/js/skype-uri.js Failed to load resource: net::ERR_INSECURE_RESPONSE

The reason is skype uses a special url for https, namely
https://secure.skypeassets.com/i/scom/js/skype-uri.js

Works fine with that code. No patch as I only need the skype_uri formatter, but I hope this info is helpful to someone.

  • c8a55e0 committed on 8.x-1.x 
    Issue #2695519: Not working if site loaded over HTTPS

  • 366a19f committed on 7.x-1.x 
    Issue #2695519: Not working if site loaded over HTTPS
robin.ingelbrecht’s picture

robin.ingelbrecht commented
Status: Active » Fixed

Fixed this issue for version D7 and D8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.