Thank you!

I periodically review all newly created modules, and this one caught my attention. Perfect timing. I've got two or three external sites (not Drupal) that needed to have the same look and feel as our www site (one of them is a legacy classic ASP site -- yuck). This module saved me a ton of time. I took the resulting page, split it in half (header.html and footer.html), then wrapped it around the other sites' content.

Some documentation would have saved me a few minutes:

  • Update the project page
  • Include a README.txt file
  • Implement hook_help()

Documentation required:

  • Where to find the CSS and JS files. It only took me a few minutes to find them (sites/default/files/skin), but a little documentation would help.
  • Where to find the html file. There isn't one. You have to view source and save. No problem with this approach, and again it only took me a few minutes to figure it out, but documentation would have helped.

Documentation suggested - best practices:

  1. Create a new, empty node of the type you wish to use for your skin, perhaps just placing the strings @@TITLE@@ and @@BODY@@ in the title and body fields respectively. This will make it easier to find these sections later when you need to edit or split the skin into header/footer sections. Searching for @@BODY@@ is faster than digging down through a zillion DIV tags.
  2. If possible, remove all blocks that you don't wish to appear in your skin (admin/build/block/list)
  3. Configure the module to skin the new page (admin/settings/skin)
  4. Visit your empty node page and capture the HTML from your browser (View Source)
  5. Retrieve the CSS and JS files from sites/default/files/skin
  6. Remove this node's path from the module's configuration page when you are finished (sites/default/files/skin).

Just some suggestions. "Take the best, leave the rest." And thanks again for sharing your work.

Comments

geerlingguy’s picture

Agreed!

joelstein’s picture

Status: Active » Fixed

@toomanypets: Thanks for the feedback and the great documentation ideas. I implemented most of them (hook_help, better documentation in the module and on the project page, and a basic README.txt file). Committed in http://drupal.org/cvs?commit=436972.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.