Problem/Motivation

I am unable to build a test site when adding additional projects and leaving the patch field empty. There is no way to remove the patch field. Clicking the "x" does not remove the patch field. So, after adding a project and an additional project without filling in a patch the build fails with error:

In PatchAddCommand.php line 75:
  Your patch url argument must be a valid URL or local path.

Steps to reproduce

(I expect the specific projects don't make a difference, but better safe than sorry).

  • On the setup form
  • Select Antibot as the primary project
  • Click Advanced options
  • Click "Add additional project"
  • Enter Gin Admin Theme
  • Click "Add additional project"
  • Enter Gin Login
  • Click "Launch sandbox" at the top, next to the primary project

Screenshot:

Screenshot of setup form to reproduce the issue

CommentFileSizeAuthor
#5 Screenshot 2024-03-20 at 09.45.20.png1.17 MBeelkeblok
#2 empty_patch.patch212 bytesjescudero
Screen Shot 2023-03-14 at 7.28.26 PM.png353.41 KBbobbysaul
Screen Shot 2023-03-14 at 7.28.17 PM.png1018.66 KBbobbysaul

Comments

bobbysaul created an issue. See original summary.

jescudero’s picture

jescudero commented
StatusFileSize
new empty_patch.patch212 bytes

Did you try to use an empty patch?

dalemoore’s picture

dalemoore commented

I ran into the same problem trying to add multiple projects to test. Your method of adding that empty patch seems to work, but it isn't documented on the page or anything.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Status: Active » Postponed (maintainer needs more info)

Hi! As I’ve been doing some issue triage, I’ve been installing lots of projects, and additional modules, with and without patches. I’m wondering if this issue is still relevant or fixed elsewhere?

Can the reporter confirm?

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new Screenshot 2024-03-20 at 09.45.20.png1.17 MB

I am running into the same issue. I think you need to add at least two additional projects. On adding the second one, a patch field appears with the first additional project. Leaving that empty will trigger the issue. I was able to reproduce the problem with the following settings for the setup form:

Screenshot of setup form to reproduce the issue

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Title: Unable to build when no patch added » Unable to build with two additional projects selected

Reworded the title. Adding an (empty) patch is the workaround, but not really the primary issue, I'd say.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue summary: View changes
mxt’s picture

mxt
Primary language Italian
Location Milan
commented

Tried today: the problem is still there.

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented

Happening for me with:

Drupal core 11.x-dev
Automated Logout 2.x-dev
Autosave Form 8.x-1.x-dev

Neither of the two added projects are my projects, so I am loath to clutter them with a blank merge request. I attempted to work around this by picking a patch from each project:

https://git.drupalcode.org/project/autologout/-/merge_requests/91.patch
https://git.drupalcode.org/project/autosave_form/-/merge_requests/34.patch

But this failed with the following message:

In Patches.php line 288:

No available patcher was able to apply patch https://git.drupalcode.org/pro
ject/autologout/-/merge_requests/91.patch to drupal/autologout