Problem/Motivation

Drupal core is a unique project. When testing just core, you would enter "drupal" from the project. This throws an error because it basically tries to require drupal inside of the existing drupal project :)

Error: "Root package drupal/drupal cannot require itself in its composer.json"

Furthermore, if drupal core is the project, the core selector under the advanced options is therefore extraneous.

Steps to reproduce

Enter drupal as the project, submit

Proposed resolution

1. Add specific logic for drupal core that would vary from other projects and/or distributions

2. Hide the core selector if/only if Drupal is selected as the project, show it if the project changes to something else besides drupal

Remaining tasks

1. React changes for conditional

2. Backend/tugboat changes for conditional logic of drupal itself

3. Automated tests

User interface changes

Conditionally showing the core selection based on project selected

API changes

n/a

Data model changes

n/a

Issue fork simplytest-3211462

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nerdstein created an issue. See original summary.

mglaman’s picture

Assigned: Unassigned » mglaman

I'll be working on this during the live stream tomorrow.

We need to:

  • If Drupal is the test project, we need to hide the Drupal core version selector in Advanced Options and have it sync with whatever was chosen in the main section.
  • Do not run require drupal/drupal at all, or map to require drupal/core
  • Make sure patches are configured to run against drupal/core

mglaman’s picture

Assigned: mglaman » Unassigned
Status: Active » Needs review

During the live stream we were able to get Drupal 9.3.x with patching! I think this is good to go after a review.

nerdstein’s picture

Status: Needs review » Fixed

Looks good, thanks!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.