Well, what a descriptive title. Anyway. Say you have an install within a subfolder of the domain: example.com/drupal. When you try to log out the module will redirect you to '/?msg=' . $msg. Which will be outside the drupal root (i.e example.com/?msg=no_slo)

Attached is a 2 liner patch to fix this.

Other than that: Great module. Keep up the good work.

CommentFileSizeAuthor
base-path-fix.patch488 byteseiriksm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geekwisdom’s picture

geekwisdom CreditAttribution: geekwisdom commented
Assigned: Unassigned » geekwisdom
Status: Needs review » Fixed

Thanks for reporting this. I corrected this in the 6.x-2.x branch. I used base_path() instead of your patch.

doublejosh’s picture

doublejosh CreditAttribution: doublejosh commented
Status: Fixed » Needs work

This also needs to be included in simplesamlphp_auth_init()in the path for "not allowed to register new users on the site through simpleSAML"

geekwisdom’s picture

geekwisdom CreditAttribution: geekwisdom commented
Version: 6.x-2.x-dev » 6.x-3.x-dev
Status: Needs work » Fixed

Good catch doublejosh. This has been corrected in 6.x-3.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.