Two <html> tags [#373915]

Why after the end of my mail there is some additional HTML?

ke.norb,

Your account at Kids has been activated.

You may now log in by clicking on this link or copying and pasting it in
your browser:
/user/reset/57/1234531155/97b4cb1cdd19c7eb7...
This is a one-time login, so it can be used only once.

After logging in, you will be redirected to
/user/57/edit so you can change your
password.

Once you have set your own password, you will be able to log in to
/user in the future using: username:
ke.norb

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">




cellpadding="0" cellspacing="0">
cellspacing="0">

Comment	File	Size	Author
#5	simplenews_template.module.patch	780 bytes	kenorb

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jerdavis

Minneapolis, MN

CreditAttribution: jerdavis commented 22 February 2009 at 01:12

Status:

Active

» Postponed (maintainer needs more info)

I'm unable to reproduce, but there have been a few changes that could impact this. Please try the latest snapshot and see if that corrects the issue.

Jer

Comment #2

kenorb CreditAttribution: kenorb commented 27 February 2009 at 15:25

It happen as well with latest snapshot.
I'll try to debug it later.

Comment #3

kenorb CreditAttribution: kenorb commented 17 March 2009 at 11:16

Status:

Postponed (maintainer needs more info)

» Closed (duplicate)

Duplicate of: #345246: Two opening body tags

Comment #4

kenorb CreditAttribution: kenorb commented 18 March 2009 at 10:41

Project:	Mime Mail	» Simplenews Template
Category:	support	» bug
Status:	Closed (duplicate)	» Active

It's the same problem, but for different branch.
So the fix should be different.

Comment #5

kenorb CreditAttribution: kenorb commented 18 March 2009 at 15:37

File	Size
simplenews_template.module.patch	780 bytes

Comment #6

kenorb CreditAttribution: kenorb commented 25 March 2009 at 10:52

Status:

Active

» Needs review

Comment #7

sersim CreditAttribution: sersim commented 26 March 2009 at 22:38

This issue can also be fixed changing line 39 (simplenews_template_mail_alter()) in this way:

  } else if (!$processed and substr($message['id'], 0, 11) == 'simplenews_') {

Comment #8

ron_s CreditAttribution: ron_s commented 21 May 2009 at 06:09

I tried to use the patch in #5, and did not fix the problem. Here is the email I received when attempting to use the basic Drupal contact form (Mime Mail HTML not used for system messages):

admin sent a message using the contact form at http://www.testsite.com/contact.

Another test message

Another line 2

Another line 3

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>: </title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css">
<!--

-->
</style>
</head>
<body bgcolor="#ffffff">
<table class="simplenews-template-background" width="100%" bgcolor="#ffffff" cellpadding="0" cellspacing="0"><tr><td valign="top" align="center">
<table class="simplenews-template-content" width="100%" cellpadding="0" cellspacing="0"><tr><td align="left">

</td></tr></table>
</td></tr></table>
</body>
</html>

Comment #9

kenorb CreditAttribution: kenorb commented 21 May 2009 at 09:45

If you saying that 'Mime Mail HTML not used for system messages', so that probably means he is.
#456260: WSOD: smtp_library variable is not removed when mimemail has been disabled
Even you will disable Mimemail, it will be still sending through Mimemail;)

Did you tried #7 as well?

There is duplicate: #345246: Two opening body tags but for 5.x

I don't remember how I solve that, but there is patch for 5.x that solved this problem on 5.x
http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/simplenews_...

Comment #10

franz

any

Montréal

CreditAttribution: franz commented 19 October 2009 at 11:24

@kenorb

The patch has to be converted to unix format (dos2unix)

Comment #11

franz

any

Montréal

CreditAttribution: franz commented 19 October 2009 at 14:09

... after which, it seems to work =)

Comment #12

franz

any

Montréal

CreditAttribution: franz commented 5 November 2009 at 17:07

Status:

Needs review

» Fixed

commited on dev.

Comment #13

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 13 November 2009 at 22:35

Status:

Fixed

» Needs work

I don't think this patch is right, has anybody actually confirms this doesn't break the actual module. I just upgraded to beta3 to try out the latest changes on the module and the template from simplenews_template haven't kicked in at all.

I think the code introduced by this patch is actually making the theme function not to be executed properly, as it mainly will make the body of the mail almost never be processed. When is $message['body'] is going to be null?

I think that the solution for the actual problem in this issue might have been addressed by #567604: simplenews_template_mail_alter() is wrongly changing every mail and removing the first letter of plain text notifications, I will try to revert this patch and commit/comment on the behavior of the module

Comment #14

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 13 November 2009 at 22:53

Status:

Needs work

» Fixed

Well, I actually rolled back this patch from CVS, I am almost sure that has not to do with this problem or the duplicate issue. I have tested with simplenews+mimemail+simplenews_template and all seems working fine w/o the patch and not with it. If I am wrong and this is actually needed, please let me know and I'll follow this one further.

Comment #15

27 November 2009 at 23:00

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #16

roball CreditAttribution: roball commented 21 December 2009 at 02:11

Title:	some broken html code after the mail	» Two <html> tags
Status:	Closed (fixed)	» Active

I am using the latest 6.x-1.x-dev version (2009-Nov-14), together with Simplenews 6.x-2.x-dev (2009-Dec-10) and Mime Mail 6.x-1.0-alpha1. The HTML part of the body of the mails sent by Simplenews looks like this:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html style="font-size:100%;">
<head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head>
<body bgcolor="#f2f7ec" style="background-color:#FFF;">
<table class="simplenews-template-background" width="100%" bgcolor="#f2f7ec" cellpadding="0" cellspacing="0" style="border-collapse:collapse;border-width:0px;font-size:1em;width:100%;margin:0010px0;"><tr style="border-spacing:0;border-collapse:collapse;border-width:0px;"><td valign="top" align="center" style="border-spacing:0;border-collapse:collapse;border-width:0px;">
<table class="simplenews-template-content" width="100%" cellpadding="0" cellspacing="0" style="border-collapse:collapse;border-width:0px;font-size:1em;width:100%;margin:0010px0;"><tr style="border-spacing:0;border-collapse:collapse;border-width:0px;"><td align="left" style="border-spacing:0;border-collapse:collapse;border-width:0px;">
<div class="simplenews-template-header">
This is the <strong>Header</strong>.
</div>
<div class="simplenews-template-body">
<h1 style="margin-bottom:0.3em;font-size:1.3em;">Test with Simplenews Template</h1>
<span class="print-link"></span><p style="margin-top:0.4em;margin-bottom:0.8em;">Dear Anonymous</p>
<p style="margin-top:0.4em;margin-bottom:0.8em;"><span style="text-decoration:  
underline;">xxx</span>:</p>
<ul style="margin:0;padding:0001em;">
<li style="line-height:1.6em;">1</li>
<li style="line-height:1.6em;">2</li>
</ul>
<p style="margin-top:0.4em;margin-bottom:0.8em;"><strong><span style="color: #ff0000;">Ã„Ã„Ã„ bbbb</span></strong></p>
</div>
<div class="simplenews-template-footer">
<br>
--<br>
You are receiving this mail because you are subscribed to the newsletter<br>
"Test". If you no longer want to receive this newsletter,<br>
you can unsubscribe by clicking the following link:
</div>

</td></tr></table>
</td></tr></table>
</body>
<html style="font-size:100%;"><body style="background-color:#FFF;">
<p class="newsletter-footer" style="margin-top:0.4em;margin-bottom:0.8em;font-size:smaller;color:gray;"><a href="https://www.mydomain.tld/drupal/newsletter/confirm/remove/xxxxxxxxxxxxxxx" style="text-decoration:none;font-weight:bold;color:#B21F88;">Unsubscribe  
from this newsletter</a></p>

      
    
  </body></html>
</html>

Comment #17

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 21 December 2009 at 13:41

Have you override any theme function in your theme? Can you try the functionality with a default garland theme?
Thanks,
a.=

Comment #18

roball CreditAttribution: roball commented 27 December 2009 at 00:57

No, I did not override a theme function. The problem also occurs with the default Garland theme:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html>
<head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head>
<body bgcolor="#f2f7ec" style="background:none;font:12px/170%Verdana,sans-serif;color:#000;width:640px;">
<table class="simplenews-template-background" width="100%" bgcolor="#f2f7ec" cellpadding="0" cellspacing="0" style="border-collapse:collapse;margin:1em0;width:100%;"><tr><td valign="top" align="center" style="padding:.3em.5em;">
<table class="simplenews-template-content" width="100%" cellpadding="0" cellspacing="0" style="border-collapse:collapse;margin:1em0;width:100%;"><tr><td align="left" style="padding:.3em.5em;">
<div class="simplenews-template-header">
<br>
This is the <strong>Header</strong>.
</div>
<div class="simplenews-template-body">
<h1 style="font-weight:normal;font-family:Helvetica,Arial,sans-serif;font-size:170%;">Test with Simplenews Template</h1>
<span class="print-link"></span><p style="margin:0.6em01.2em;padding:0;">Dear Anonymous</p>
<p style="margin:0.6em01.2em;padding:0;"><span style="text-decoration:  
underline;">xxx</span>:</p>
<ul style="margin:0.5em01em;">
<li>1</li>
<li>2</li>
</ul>
<p style="margin:0.6em01.2em;padding:0;"><strong><span style="color: #ff0000;">Ã„Ã„Ã„ bbbb</span></strong></p>
</div>
<div class="simplenews-template-footer">
<br>
--<br>
Â© 2010, ISEKI-Food Association<br>
You are receiving this mail because you are subscribed to the newsletter<br>
"IFA eNews". If you no longer want to receive this newsletter,<br>
you can unsubscribe by clicking the following link:
</div>

</td></tr></table>
</td></tr></table>
</body>
<html><body style="background:none;font:12px/170%Verdana,sans-serif;color:#000;width:640px;">
<p class="newsletter-footer" style="margin:0.6em01.2em;font-size:smaller;color:gray;"><a href="https://www.mydomain.tld/drupal/newsletter/confirm/remove/xxxxxxxxxxxxxxx">Unsubscribe  
from this newsletter</a></p>

      
    
  </body></html>
</html>

Comment #19

roball CreditAttribution: roball commented 27 December 2009 at 12:55

In the meantime, I have uninstalled the "Simplenews Template" module and now use the "simplenews-newsletter-body--[tid].tpl.php" and "simplenews-newsletter-footer--[tid].tpl.php" files directly from the "Simplenews" module. This solved the problem, so it seems to be caused by "Simplenews Template".

Comment #20

smk-ka CreditAttribution: smk-ka commented 27 July 2010 at 23:06

There is definitely something fishy going on when using the combination of simplenews, simplenews_template and mimemail. Both simplenews_template (during hook_mail_alter()) and mimemail (when finally sending the email in its drupal_mail_wrapper() implementation) wrap the email into a HTML structure, resulting in duplicated markup. I did only a short test, but eventually I disabled simplenews_template altogether and styled the email purely using mimemail's mimemail-message.tpl.php, which works if your email style may be applied to all outgoing emails (not just newsletters). However, some of the advanced features of simplenews_template, like preventing simplenews from inserting its title, are then not available.

I'm not sure what's the correct solution here, but since mimemail provides the HTML wrapping, I think simplenews_template should maybe avoid outputting its own markup scaffold.

An alternative solution might be simplenews_template still outputs full HTML and implements its own incarnation of mimemail_message.tpl.php based on mailkey, which simply passes the email through (i.e. to avoid adding markup again). But then again, it was only a short test.

Comment #21

webavant CreditAttribution: webavant commented 30 July 2010 at 21:31

theme_simplenews_template_content() is being called for me, and I confirmed because I was able to eliminate the

that is inserted in the module's function, but the tag is still inserted regardless that I removed it from my theme function. I imagine this has something to do with the way the theme engine works, but I just don't know.