Replace subscriber overview with views

Promoting as discussed in #2401019: Enable commented out tests in 8.x-1.x

Don't forget to add exposed filters to the admin view.
Due to the subscriber view with subscription relationships the exposed subscription filters might be quite a bit of work.

We can also make advanced exposed filter a followup. But they should be defined before closing this issue.

Preferred filters:
- Published status
- Newsletter
- Send status

We should create a view header plugin that checks for newsletters. If one newsletter is sending, we should display an info message on how to stop.
Or we can also just add a visual emphasis and possibly extend the operations?
Problem is: All send status, send and stop sending are on the same tab.
See also the operations issue: #2413931: Admin UI: Newsletter issue operations

Sounds like an interesting idea, but follow-up material :)

I started adding views integration to polls recently (#2409887: Views integration) and would suggest a similar approach as I started with there:

1. Add the default entity views data handler to subscribers and build an initial version of the subscriber and issue UI, disable whatever views hooks we currently still implement.
2. Identify missing functionality, check if there are core issues that would improve/provide them (e.g. the links issue that I linked in the poll issue)
3. Push the core issues and whatever custom integration (data definitions and plugins) that we need.
4. Drop the old code that we no longer need, enable tests that are curently disabled for those views.

That can happen in the same issue (except some additioal features that are not critical functionality like the header idea above) but I think we should split subscribers and issues up, they will hardly have anything in common.

Changing title, reducing to subscriber view.
Split off part: #2413995: Replace newsletter issue overview with views

Lets depend simplenews on views, at least temporarily, to figure out if there are test fails caused by the switch.

Also search for "@todo Enable these tests again in https://www.drupal.org/node/2401019.", figure out which of those tests apply to the subscriber overview. There are tests for the email filter for example, try to make them work again. Note that views filters use GET, that might be a problem with testing.

Looks pretty nice. Some small fixes. Will commit when passing again.

1. +++ b/config/install/views.view.simplenews_subscribers.yml
   @@ -0,0 +1,783 @@
   +          label: 'User name'
   
   +++ b/src/SubscriberViewsData.php
   @@ -0,0 +1,41 @@
   +        'title' => $this->t('User name'),
   

   Core mentions "Username" in the people view. I guess we should do it exactly the same.

2. +++ b/simplenews.views.inc
   @@ -5,6 +5,25 @@
   +    if($field_storage->getType() == 'simplenews_subscription') {
   

   Please check all codestyle.

As discussed, drop the subscriber list builder and then we should be done here.

1. +++ b/config/install/views.view.simplenews_subscribers.yml
   @@ -0,0 +1,707 @@
   +uuid: bcacf942-0be0-4960-9206-060aede4bd20
   

   uuid needs to be removed.

2. +++ b/simplenews.views.inc
   --- a/src/Entity/Subscriber.php
   +++ b/src/Entity/Subscriber.php
   
   +++ b/src/Entity/Subscriber.php
   +++ b/src/Entity/Subscriber.php
   @@ -29,7 +29,9 @@ use Drupal\user\UserInterface;
   
   @@ -29,7 +29,9 @@ use Drupal\user\UserInterface;
     *       "block" = "Drupal\simplenews\Form\SubscriptionsBlockForm",
     *       "page" = "Drupal\simplenews\Form\SubscriptionsPageForm",
     *       "delete" = "Drupal\simplenews\Form\SubscriberDeleteForm",
   - *     }
   

   list builder is not removed?

3. +++ b/src/SubscriberViewsData.php
   @@ -0,0 +1,48 @@
   +    $data['simplenews_subscriber']['user_name'] = array(
   +      'real field' => 'uid',
   +      'field' => array(
   +        'title' => $this->t('Username'),
   +        'help' => $this->t('Provide a simple link to the subscriber\'s user account .'),
   +        'id' => 'simplenews_user_name',
   

   Add a @todo on the issue you created here with the core problem.

4. +++ b/src/Tests/SimplenewsAdministrationTest.php
   @@ -26,6 +26,18 @@ use Drupal\simplenews\Entity\Subscriber;
      /**
   +   * Disabled config schema checking temporarily until all errors are resolved.
   +   */
   +  protected $strictConfigSchema = FALSE;
   

   Why is this here? We should fix the fails.

5. +++ b/src/Tests/SimplenewsAdministrationTest.php
   @@ -26,6 +26,18 @@ use Drupal\simplenews\Entity\Subscriber;
   +  /**
   +   * Modules to enable.
   +   *
   +   * @var array
   +   */
   +  public static $modules = array('views');
   

   This is wrong, you need to add it to simplenews.info.yml instead.

6. +++ b/src/Tests/SimplenewsAdministrationTest.php
   @@ -606,7 +610,7 @@ class SimplenewsAdministrationTest extends SimplenewsTestBase {
       */
   -  function testContentTypes() {
   +  function atestContentTypes() {
        $admin_user = $this->drupalCreateUser(array(
   
   @@ -674,4 +678,41 @@ class SimplenewsAdministrationTest extends SimplenewsTestBase {
   +   * Test content subscription status filter in subscriber view.
   +   */
   +  function atestSubscriberStatusFilter() {
   

   disabled tests.

Ok, committed and pushed.