Implement Hook for when newsletters are sent

+++ b/includes/simplenews.admin.incundefined
@@ -267,7 +267,7 @@ function simplenews_issue_send($nids) {
-    simplenews_add_node_to_spool($node);
+    module_invoke_all('simplenews_send', $node);

Adding a hook sound useful but it's not necessary to change the API for this. Simply place the module_invoke_all() call inside simplenews_add_node_to_spool().

Then your patch is simplified to an additional line + maybe a comment and the api.php changes.

+++ b/simplenews.api.phpundefined
@@ -50,10 +50,15 @@
 /**
- * @defgroup spool Mail spool
+ *  Hook is called a newsletter is sent.
  *
- * @todo
+ *  Simplenews uses this hook to add the newsletter to the outgoing mail spool
+ *  @param stdObject $node The newsletter being sent
+ *  ¶
+ *  @return All return values are ignored
  */
+function hook_simplenews_send($node) {

Looks like you've overriden one of the placeholder defgroups. We do want to keep that..

+++ b/includes/simplenews.mail.incundefined
@@ -37,6 +37,9 @@ function simplenews_add_node_to_spool($node) {
+  ¶
+  //Notify other modules that a newsletter was just sent

Trailing space on the first line.

Comments should have a space after the // and end with a .

Looks good after this, much simpler now :)

#8: hook_simplenews_send-1560084-7.patch queued for re-testing.

This is a problem with the test, that one fails sometimes. Triggered a re-test.

Actually, let's just name the variable @node and also add a @param to the docblock explaining that this is the sent node.

It's not the newsletter/category that we are passing to that function.

Looks good, commited, thanks!