Problem/Motivation

The template.php file has lots of inline code additions that should be moved to a separated file in order to be clean and easily maintainable.

Proposed resolution

  1. Move the custom main menu code to a separated file called main_menu.js
  2. Update drupal_add_js to call a file instead of adding an inline code.
  3. Fix Drupal JavaScript coding standards issues.

@see https://drupal.org/node/172169 and https://drupal.org/node/1720586

CommentFileSizeAuthor
#2 2163219.patch8.31 KBshewaleanjali
#1 simplecorp-patch.zip4.55 KBshewaleanjali

Comments

shewaleanjali’s picture

shewaleanjali commented
StatusFileSize
new simplecorp-patch.zip4.55 KB

Hi,
Done the chnages suggested.
1. Moved the main menu code to separate file called main_menu.js
2. Updated drupal_add_js to call
3. Fixed Drupal JavaScript coding standards issues.

shewaleanjali’s picture

shewaleanjali commented
Status: Active » Needs review
StatusFileSize
new 2163219.patch8.31 KB

Added patch file for the same.

donapis’s picture

donapis commented
Status: Needs review » Reviewed & tested by the community