Why aren't the ad statistics working?

Hi, Please try to remove the module from the site, clear the cache, run cron. And then try to install it again and see if you still can reproduce the issue.
Thank you.

No, you don't need to wait, it should increase all counters immediately.
- Do you see any error messages in logs ?

I need more information from you in order to try replicate the problem.

Please check impressions/counts table in the database and confirm that the table has records.

Also please read this:

If your site is behind a reverse proxy (e.g. Varnish) the unique impressions
count will be incorrect because it will record the IP address of the proxy
rather than the client. Make sure you set variables 'reverse_proxy' and
'reverse_proxy_addresses' to suit your infrastructure.

Enable "Count impressions" and "Count clicks" for anonymous users. Then open different browser and keep clicking ads and refreshing the page. MAKE SURE that you are not logged in.

Can you show me redirection URLs ?

Statistics works good in 1.7!

rimbah, try to log out and you will see magic.
I think this behaviour just perfect. Admin always gets to advertisment node, where he can change settings, while simple users being redirected to redirection url.

Make sure that your ad url has http(s): in it. e.g http://google.com and not "google.com".

This is weird, at least it should show something like simpleads/redirect/[node_id] or simpleads/redirec/www.google.com in case if your link missing "http(s)://" (in 7.17 version, this is fixed in dev version).

What's the default language of your site ?

and what does [nr] mean ?

Could you write all the steps that you are doing to install SimpleAds ?

hm, I have no idea why this happening to you.
Could you also try directly access redirection URL: http://yourisetname/simpleads/redirect/[ad_node_id] (as anonymous user).

Maybe you have older theme templates that overrides newer ones?

Any update on this issue?

I am sorry that I wasn't able to help you with this. Currently I am extremely busy on some big projects and most likely I can take a look at this next month.
Please keep me posted.

Thanks,

Minnur

Thanks for the update. I am closing this issue.

Seems to be active again in the 7.x-2.x-dev snapshot, atleast from today.

I have uploaded an image and given it a destination URL, ie http://google.com/

but the link on the image goes directly to http://google.com, no stats or redirects are present, The stats page for the node just has the headers for the stats table and no data/rows

Ehhh i'm starting to think this is a different issue, it could be the lack of documentation that's causing the issue

+-----+-------+------------+----------------+------+
| aid | nid   | timestamp  | ip_address     | url  |
+-----+-------+------------+----------------+------+
|   1 | 98622 | 1371654559 | 123.23.123.123   | NULL |
|   2 | 98622 | 1371678945 | 123.123.123.123 | NULL |
|   3 | 98622 | 1371681377 | 123.123.123.123 | NULL |
+-----+-------+------------+----------------+------+
3 rows in set (0.17 sec)

I'm seeing some stats in the table, but the is going directly without any redirect, so i guess there must be some other hook going on?

however stats arent showing on that page just yet, really confusing :/ sorry

Ads show up after some time, tho not after running the cron job directly (using ultimatecron) must be some other rule that triggers them

It's only running on cron if the date is different (not including time). Meaning, every 24 hours it collects statistics.

if ( date( 'm-d-Y', $timestamp ) != date( 'm-d-Y', REQUEST_TIME ) ) {

dgtlmoon, thanks for clarification.

Is it possible to get statistics sooner than the next day? ie: hourly like the 1.8 version does?

So I've been looking at this, because I'm reviewing the module for a client.

I've looked through the code, and as duntuk mentioned, it's only updating the stats once a day. This is a huge problem, because if you run cron frequently (as this client does) The first run will then lock out anymore stats updates for the whole day, so a lot of the ads will never disable. I've looked in the code, and the only insert reference to the `simpleads_stats` is in the cron hook.

In my case, my impressions and clicks are recording, but because the simpleads_stats only gets updated on cron, and all of the checks to display the stats or hide the ads depend on this table, it's a huge problem. There needs to be a hook on every impression/click that's recorded that does the job of the following in the cron hook.

db_merge('simpleads_stats')
      ->key(array('nid' => $row->nid, 'date' => $row->date))
      ->fields(array(
        'nid' => $row->nid,
        'date' => $row->date,
        'clicks' => 0,
        'clicks_unique' => 0,
        'impressions' => $row->all_count,
        'impressions_unique' => $row->unique_count,
      ))
      ->execute();

I haven't looked at the 1.8 version, but it seemed to have actively updated stats (when it worked) and also showed the hourly stats. Now the module only works in 24hr intervals, which for sites that have a lot of traffic and rely on the click/impression limits, this won't work.

For my review purposes, this module is the only one that really fits the need, but to use it, I'd need to fix it, and I'm not sure the client will pay me to do that, sadly.

I attempted to access the redirect url directly using the format http://mysite/simplads/redirect/[nid] but this failed. After taking a look in simpleads.module I noticed the following:

<?php
    $items['node/%node/stats/redirect'] = array( 
?>

I adjust my view URL rewrite to read a href="/node/[nid]/stats/redirect" and that worked.

I'll see tomorrow (on daily cron?) if those clicks were actually tracked though.

@chrisdkemper, I'm not a developer but a quick look in the module makes me wonder, wouldn't changing the following lines (in cron.inc) change when stats are aggregated?

19 | WHERE FROM_UNIXTIME(s.timestamp, '%Y-%m-%d') BETWEEN CURDATE() - INTERVAL 1 DAY AND CURDATE() - INTERVAL 1 SECOND
...
50 | WHERE FROM_UNIXTIME(s.timestamp, '%Y-%m-%d') BETWEEN CURDATE() - INTERVAL 1 DAY AND CURDATE() - INTERVAL 1 SECOND

Hi, i am having the same problem. Everything was working fine on live site, then suddenly the module stopped tracking the stats of ads. Im using version 7x.1.8

Hi all,

We're currently using Simpleads 7.x-2.x-dev on a client's site. He is reporting the print stats are not matching what google analytics shows (total prints on a page where my ad shows up). After looking into some reported issues, and analyzing the code for a while, we got to the conclusion that the current way stats are being aggregated might be causing the issue, specially if cron is run once a day. Here's why:

If cron runs once a day, it retrieves all prints from a day ago, but only that day, leaving out all today’s prints. So say we run cron today at 10pm (today is 2018-04-11). The FROM_UNIXTIME(timestamp, '%Y-%m-%d') BETWEEN CURDATE() - INTERVAL 1 DAY AND CURDATE() - INTERVAL 1 SECOND where clause would be between 2018-04-10 and 2018-04-10 23:59:59; but leaving out all today’s prints since 2018-04-11 00:00:01. Then it will aggregate yesterday's data, and wipe out all prints for any ads aggregated. This cycle repeats every day.

As you can see, there will be data lost (not aggregated) every day. The next day it will aggregate all data from 2018-04-11 to 2018-04-11 23:59:59, but without the prints that were deleted.

We worked on a patch that we're still testing, based on https://www.drupal.org/project/simpleads/issues/2449663#comment-11124609, but adjusted to work in version 7.x-2.x. It seems to be working for us.

I hope this helps solve this issue.

Regards.

Fixing small issue in #49 patch from automated test.

Another small change.