Automated Drupal 11 compatibility fixes for simple_sitemap [#3434566]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

If the issue is reopened, then new automated changes will be posted.

If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

Review the merge request and test it.
Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#16	simple_sitemap.4.x-dev.upgrade_status.post_rector.txt	4.95 KB	project update bot
#16	simple_sitemap.4.x-dev.rector.patch	3.54 KB	project update bot
#16	interdiff-last-bot.6944859.txt	358 bytes	project update bot
#13	simple_sitemap.4.x-dev.upgrade_status.post_rector.txt	4.95 KB	project update bot
#13	simple_sitemap.4.x-dev.rector.patch	3.02 KB	project update bot
#13	interdiff-last-bot.6917240.txt	1.35 KB	project update bot
#2	simple_sitemap.4.1.8.upgrade_status.post_rector.txt	4.53 KB	project update bot
#2	simple_sitemap.4.1.8.rector.patch	3.02 KB	project update bot

Issue fork simple_sitemap-3434566

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3434566-drupal-11 changes, plain diff MR !101
Check out this branch for the first time

Check out existing branch, if you already have it locally

3 hidden branches

project-update-bot-only

changes, plain diff MR !90

Check out this branch for the first time

Check out existing branch, if you already have it locally

3434566-d11-ready

changes, plain diff MR !99

Check out this branch for the first time

Check out existing branch, if you already have it locally

3434566-automated-drupal-11

changes, plain diff MR !98

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

25 March 2024 at 00:33

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 25 March 2024 at 00:33

Status:

Active

» Needs review

Status	File	Size
new	simple_sitemap.4.1.8.rector.patch	3.02 KB
new	simple_sitemap.4.1.8.upgrade_status.post_rector.txt	4.53 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

drupal/upgrade_status: 4.1.0
mglaman/phpstan-drupal: 1.2.9
palantirnet/drupal-rector: 0.20.1

Comment #3

25 March 2024 at 00:34

Project Update Bot opened merge request !90

Comment #4

14 May 2024 at 08:03

ankitv18 made their first commit to this issue’s fork.

Comment #5

ankitv18 commented 14 May 2024 at 09:21

Version:	4.1.8	» 4.x-dev
Issue summary:	View changes

Comment #6

14 May 2024 at 10:03

Rajeshreeputra made their first commit to this issue’s fork.

Comment #7

vishalkhode commented 16 May 2024 at 04:40

Status:

Needs review

» Needs work

There are couple of PHPUnit tests are failing on Drupal 11 and this needs to be fixed

1) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testSitemapSupportForViews
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

2) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testIndexableViews
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

3) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testAddArgumentsToIndex
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

4) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testViewsUrlGenerator
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

5) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testGarbageCollector
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for views.view.simple_sitemap_views_test_view with the following errors: views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.type.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.title.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.default.display_options.arguments.nid.default_argument_skip_url missing schema, views.view.simple_sitemap_views_test_view:display.page_2.display_options.arguments.type.default_argument_skip_url missing schema

/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:98
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/Users/user1/drupal11/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Config.php:230
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:260
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php:486
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:239
/Users/user1/drupal11/web/core/lib/Drupal/Core/Entity/EntityBase.php:354
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:610
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:389
/Users/user1/drupal11/web/core/lib/Drupal/Core/Config/ConfigInstaller.php:149
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/Users/user1/drupal11/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:322
/Users/user1/drupal11/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/Users/user1/drupal11/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:500
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:575
/Users/user1/drupal11/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTestBase.php:80
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/modules/simple_sitemap_views/tests/src/Functional/SimpleSitemapViewsTestBase.php:62
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

6) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testAddCustomLink
Behat\Mink\Exception\ResponseTextException: The text "/node/1 0.2 monthly" was not found anywhere in the text of the current page.

/Users/user1/drupal11/vendor/behat/mink/src/WebAssert.php:907
/Users/user1/drupal11/vendor/behat/mink/src/WebAssert.php:293
/Users/user1/drupal11/web/core/tests/Drupal/Tests/WebAssert.php:975
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:127
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

7) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testLocking
Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save configuration" not found.

/Users/user1/drupal11/web/core/tests/Drupal/Tests/WebAssert.php:158
/Users/user1/drupal11/web/core/tests/Drupal/Tests/UiHelperTrait.php:78
/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:170
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

8) Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest::testLinkCount
Undefined array key 0

/Users/user1/drupal11/web/modules/contrib/simple_sitemap/tests/src/Functional/SimplesitemapTest.php:321
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

--

There was 1 risky test:

1) Drupal\Tests\simple_sitemap_views\Functional\SimpleSitemapViewsTest::testSitemapSupportForViews
This test did not perform any assertions

/Users/user1/drupal11/web/core/tests/Drupal/Tests/Listeners/DrupalListener.php:61
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestResult.php:453
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/Users/user1/drupal11/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/Command.php:146
/Users/user1/drupal11/vendor/phpunit/phpunit/src/TextUI/Command.php:99

Comment #8

rajeshreeputra

he/him

Pune

commented 20 May 2024 at 07:39

Status:	Needs work	» Needs review
Related issues:		+#3447048: Fix phpcs issue/warnings.

For phpcs issue/warnings fixes please see #3447048: Fix phpcs issue/warnings..

Comment #9

walkingdexter commented 20 May 2024 at 16:02

Status:

Needs review

» Needs work

I'm not sure about these changes:

They need to be carefully reviewed. At least there is no need to change the file mode. Additionally, any errors from the validate step should be fixed.

Comment #10

rajeshreeputra

he/him

Pune

commented 21 May 2024 at 13:09

Additionally, any errors from the validate step should be fixed.

PHPCS: Fixed warnings.
Eslint: We will retain this for the maintainer to take appropriate action.
PHPStan: Already appended the 'ignore next line' directive, but it appears to be non-functional.

https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/90/di...

Please see change log https://www.drupal.org/node/3382316

https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/90/di...

Please see change log https://www.drupal.org/node/3440502

Comment #11

rajeshreeputra

he/him

Pune

commented 21 May 2024 at 13:21

Status:

Needs work

» Needs review

Comment #12

vishalkhode commented 21 May 2024 at 18:37

Status:

Needs review

» Reviewed & tested by the community

@Rajeshreeputra Reviewed MR and changes looks good to me.

@WalkingDexter: If your plan is to make a new major release support starting from Drupal Core 10.1.x or If plan is to make a patch release for the same reason, then we can merge the changes. If not, then we need to add the DeprecationHelper class in the module itself, so that it works on Drupal Core 9.3.x as well.

Comment #13

project update bot commented 2 June 2024 at 17:58

Issue summary:	View changes
Status:	Reviewed & tested by the community	» Needs review

Status	File	Size
new	interdiff-last-bot.6917240.txt	1.35 KB
new	simple_sitemap.4.x-dev.rector.patch	3.02 KB
new	simple_sitemap.4.x-dev.upgrade_status.post_rector.txt	4.95 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.2
mglaman/phpstan-drupal: 1.2.11
palantirnet/drupal-rector: 0.20.2

Comment #14

12 June 2024 at 04:57

Rajeshreeputra opened merge request !98

Comment #15

12 June 2024 at 04:57

Rajeshreeputra changed the visibility of the branch project-update-bot-only to hidden.

Comment #16

project update bot commented 18 June 2024 at 03:55

Status	File	Size
new	interdiff-last-bot.6944859.txt	358 bytes
new	simple_sitemap.4.x-dev.rector.patch	3.54 KB
new	simple_sitemap.4.x-dev.upgrade_status.post_rector.txt	4.95 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Debug information

Bot run #11-199781

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.2
mglaman/phpstan-drupal: 1.2.11
palantirnet/drupal-rector: 0.20.3

Comment #17

walkingdexter commented 21 June 2024 at 08:56

Issue summary:	View changes
Status:	Needs review	» Needs work

I still see a lot of unnecessary changes that are not related to the issue. Please explain why these changes are needed. In my opinion, the only changes we need here are the changes that Project-Update-Bot suggests. Also we cannot rely on DeprecationHelper as it's available since version 10.1.3 (see the change record). We must either drop support for Drupal 9 or implement a workaround.

Comment #18

rajeshreeputra

he/him

Pune

commented 21 June 2024 at 12:57

I concur with your assessment, @WalkingDexter, that support for D9 and D10.1 can be discontinued. Additionally, the changes related to PHPSC can be effectively addressed within the scope of a separate ticket. Will create separate ticket for the same and segregate the changes accordingly.

Comment #19

rajeshreeputra

he/him

Pune

commented 21 June 2024 at 12:57

Assigned:

Unassigned

» rajeshreeputra

Comment #20

22 June 2024 at 09:27

ankitv18 opened merge request !99

Comment #21

22 June 2024 at 11:04

ankitv18 changed the visibility of the branch 3434566-automated-drupal-11 to hidden.

Comment #22

ankitv18 commented 22 June 2024 at 11:05

Assigned:	rajeshreeputra	» Unassigned
Status:	Needs work	» Needs review

Please review MR!99

Comment #23

16 July 2024 at 12:13

WalkingDexter changed the visibility of the branch project-update-bot-only to active.

Comment #24

16 July 2024 at 17:57

WalkingDexter opened merge request !101

Comment #25

16 July 2024 at 18:03

WalkingDexter changed the visibility of the branch 3434566-d11-ready to hidden.

Comment #26

16 July 2024 at 18:03

WalkingDexter closed merge request !98

Comment #27

16 July 2024 at 18:04

WalkingDexter closed merge request !99

Comment #28

16 July 2024 at 20:18

WalkingDexter committed 88db6a63 on 4.x

Issue #3434566 by ankitv18, Rajeshreeputra, WalkingDexter, vishalkhode:...

Comment #29

walkingdexter commented 16 July 2024 at 20:26

Status:

Needs review

» Active

Merged with changes and additions, thanks! Also dropped support for Drupal 9. All credits saved.

Comment #30

walkingdexter commented 21 July 2024 at 10:48

Status:

Active

» Fixed

Comment #31

vipin.mittal18

He/Him

English

Greater Noida, India

commented 30 July 2024 at 07:52

Hello @WalkingDexter,

We are approaching the release of Drupal 11, so should we expect stable version for this module before that release? Thanks!

Comment #32

walkingdexter commented 9 August 2024 at 11:49

We are approaching the release of Drupal 11, so should we expect stable version for this module before that release?

I don't have permission to create new releases. Only @gbyte can do this.

Comment #33

d.fisher commented 14 August 2024 at 13:06

+1 for full release! Appreciate all of your hard work on this. All of our sites use this module and we're currently auditing D11 compatibility and this module is a blocker across all of our sites.